Re: [PATCH iproute2-next v2] ip: Fix rx_otherhost_dropped support

[Petr Machata <petrm@nvidia.com>]

David Ahern <dsahern@gmail.com> writes:

> On 6/28/22 4:19 AM, Petr Machata wrote:
>> The commit cited below added a new column to print_stats64(). However it
>> then updated only one size_columns() call site, neglecting to update the
>> remaining three. As a result, in those not-updated invocations,
>> size_columns() now accesses a vararg argument that is not being passed,
>> which is undefined behavior.
>> 
>> Fixes: cebf67a35d8a ("show rx_otherehost_dropped stat in ip link show")
>> CC: Tariq Toukan <tariqt@nvidia.com>
>> CC: Itay Aveksis <itayav@nvidia.com>
>> Signed-off-by: Petr Machata <petrm@nvidia.com>
>> ---
>> 
>> Notes:
>>     v2:
>>     - Adjust to changes in the "32-bit quantity" patch
>>     - Tweak the commit message for clarity
>> 
>>  ip/ipaddress.c | 8 +++++---
>>  1 file changed, 5 insertions(+), 3 deletions(-)
>> 
>
> I merged main into next and now this one needs to be rebased.

The issue is that this depends on 329fda186156 ("ip: Fix size_columns()
invocation that passes a 32-bit quantity"), which got to net only
yesterday. When it's merged to next, this patch should apply cleanly.