From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA073C433F5 for ; Tue, 15 Feb 2022 06:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234363AbiBOGUx (ORCPT ); Tue, 15 Feb 2022 01:20:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbiBOGUw (ORCPT ); Tue, 15 Feb 2022 01:20:52 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34BAB11D7AD; Mon, 14 Feb 2022 22:20:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B3904614F9; Tue, 15 Feb 2022 06:20:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13D28C340EC; Tue, 15 Feb 2022 06:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644906042; bh=h1/xuj33lBeCqMBbKoIaBsOtevsxEy1crRSkrqybK/A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=MCiHgsBD/yqq251oFMZGaa2ggXeTw76tIcPtGpat0oO9DmnKJFBtZLm+7CR1NTgMj OkwR7dFs0TbkbRI47JPAcunCAP86JAbxjvxtOsU1kSHz8S6m1C8KuOUuVPl7dmK2iM Kr+QDrpTPmvLubffXH4bVttvaxDym6zfLVuS1KCR+FcaHulvlO67M0DxcvKkKBoquh bbchgKzzya8et+Dha3hXAsLOzpwTd9hfoNIy9bW+fyS2aFTsCe3HTs0NomvzPOYnNB kcyDN1J+6LgJm6FitW3FF9k83Gtq0aLUWjLAfSBKBkDc6CxIbV/nOM3r+rf6PwguMb Vo9nAqw+vVLYA== From: Kalle Valo To: davidcomponentone@gmail.com Cc: toke@toke.dk, davem@davemloft.net, kuba@kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Guang , Zeal Robot Subject: Re: [PATCH] ath9k: use swap() to make code cleaner References: Date: Tue, 15 Feb 2022 08:20:37 +0200 In-Reply-To: (davidcomponentone's message of "Tue, 15 Feb 2022 08:52:29 +0800") Message-ID: <87sfsk1wi2.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org davidcomponentone@gmail.com writes: > From: Yang Guang > > Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid > opencoding it. Liki Jiri mentioned in the ath5k patch, shouldn't you include that file? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches