From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Andrii Nakryiko <andriin@fb.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org, ast@fb.com,
daniel@iogearbox.net
Cc: andrii.nakryiko@gmail.com, kernel-team@fb.com,
Andrii Nakryiko <andriin@fb.com>
Subject: Re: [PATCH bpf-next 00/10] bpf_link observability APIs
Date: Fri, 24 Apr 2020 13:40:16 +0200 [thread overview]
Message-ID: <87sggt3ye7.fsf@toke.dk> (raw)
In-Reply-To: <20200424053505.4111226-1-andriin@fb.com>
Andrii Nakryiko <andriin@fb.com> writes:
> This patch series adds various observability APIs to bpf_link:
> - each bpf_link now gets ID, similar to bpf_map and bpf_prog, by which
> user-space can iterate over all existing bpf_links and create limited FD
> from ID;
> - allows to get extra object information with bpf_link general and
> type-specific information;
> - implements `bpf link show` command which lists all active bpf_links in the
> system;
> - implements `bpf link pin` allowing to pin bpf_link by ID or from other
> pinned path.
>
> rfc->v1:
> - dropped read-only bpf_links (Alexei);
Just to make sure I understand this right: With this change, the
GET_FD_BY_ID operation will always return a r/w bpf_link fd that can
subsequently be used to detach the link? And you're doing the 'access
limiting' by just requiring CAP_SYS_ADMIN for the whole thing. Right? :)
-Toke
next prev parent reply other threads:[~2020-04-24 11:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 5:34 [PATCH bpf-next 00/10] bpf_link observability APIs Andrii Nakryiko
2020-04-24 5:34 ` [PATCH bpf-next 01/10] bpf: refactor bpf_link update handling Andrii Nakryiko
2020-04-24 5:34 ` [PATCH bpf-next 02/10] bpf: allocate ID for bpf_link Andrii Nakryiko
2020-04-24 5:34 ` [PATCH bpf-next 03/10] bpf: support GET_FD_BY_ID and GET_NEXT_ID " Andrii Nakryiko
2020-04-24 5:34 ` [PATCH bpf-next 04/10] bpf: add support for BPF_OBJ_GET_INFO_BY_FD " Andrii Nakryiko
2020-04-24 5:35 ` [PATCH bpf-next 05/10] libbpf: add low-level APIs for new bpf_link commands Andrii Nakryiko
2020-04-24 5:35 ` [PATCH bpf-next 06/10] selftests/bpf: test bpf_link's get_next_id, get_fd_by_id, and get_obj_info Andrii Nakryiko
2020-04-24 5:35 ` [PATCH bpf-next 07/10] bpftool: expose attach_type-to-string array to non-cgroup code Andrii Nakryiko
2020-04-24 10:32 ` Quentin Monnet
2020-04-24 16:27 ` Andrii Nakryiko
2020-04-24 17:08 ` Quentin Monnet
2020-04-25 0:12 ` Andrii Nakryiko
2020-04-25 10:19 ` Quentin Monnet
2020-04-24 5:35 ` [PATCH bpf-next 08/10] bpftool: add bpf_link show and pin support Andrii Nakryiko
2020-04-24 10:32 ` Quentin Monnet
2020-04-24 16:30 ` Andrii Nakryiko
2020-04-24 5:35 ` [PATCH bpf-next 09/10] bpftool: add bpftool-link manpage Andrii Nakryiko
2020-04-24 10:33 ` Quentin Monnet
2020-04-24 16:32 ` Andrii Nakryiko
2020-04-24 5:35 ` [PATCH bpf-next 10/10] bpftool: add link bash completions Andrii Nakryiko
2020-04-24 10:33 ` Quentin Monnet
2020-04-24 11:40 ` Toke Høiland-Jørgensen [this message]
2020-04-24 15:54 ` [PATCH bpf-next 00/10] bpf_link observability APIs Andrii Nakryiko
2020-04-24 16:39 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sggt3ye7.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).