From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Florian Westphal <fw@strlen.de>
Cc: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] netlink: make getters tolerate NULL nla arg
Date: Fri, 17 Jan 2020 17:26:40 +0100 [thread overview]
Message-ID: <87sgkeoxq7.fsf@toke.dk> (raw)
In-Reply-To: <20200117103957.GV795@breakpoint.cc>
Florian Westphal <fw@strlen.de> writes:
> Toke Høiland-Jørgensen <toke@redhat.com> wrote:
>> And that the crashes at least shine a light on
>> them forcing people to consider whether that is indeed the case?
>>
>> (IDK if that's actually the case, I'm asking :))
>
> All I was saying is that if the getters were more tolerant a few crash
> bugs could have been avoided.
Sure, and all I'm saying is that that is fine, as long as it doesn't
just turn an obvious crash into a not-so-obvious behavioural bug :)
-Toke
next prev parent reply other threads:[~2020-01-17 16:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 14:55 [PATCH net-next] netlink: make getters tolerate NULL nla arg Florian Westphal
2020-01-16 15:19 ` Toke Høiland-Jørgensen
2020-01-16 16:04 ` Florian Westphal
2020-01-16 16:23 ` Toke Høiland-Jørgensen
2020-01-17 10:39 ` Florian Westphal
2020-01-17 16:26 ` Toke Høiland-Jørgensen [this message]
2020-01-17 12:08 ` David Miller
2020-01-19 12:32 ` Florian Westphal
2020-01-19 14:08 ` David Miller
2020-01-17 22:28 ` kbuild test robot
2020-01-18 9:40 ` kbuild test robot
2020-01-24 15:47 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgkeoxq7.fsf@toke.dk \
--to=toke@redhat.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).