From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: b43: Replace mdelay with msleep in b43_radio_2057_init_post Date: Mon, 08 Jan 2018 19:06:24 +0200 Message-ID: <87shbg2sbz.fsf@kamboji.qca.qualcomm.com> References: <1514632107-14698-1-git-send-email-baijiaju1990@gmail.com> <20180108162128.6D37560B1D@smtp.codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kstewart-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, tiwai-l3A5Bk7waGM@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, andrew.zaborowski-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Jia-Ju Bai , b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org To: Larry Finger Return-path: In-Reply-To: (Larry Finger's message of "Mon, 8 Jan 2018 10:31:56 -0600") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "b43-dev" Errors-To: b43-dev-bounces+gldbd-bcm43xx-dev=gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: netdev.vger.kernel.org Larry Finger writes: > On 01/08/2018 10:21 AM, Kalle Valo wrote: >> Jia-Ju Bai wrote: >> >>> b43_radio_2057_init_post is not called in an interrupt handler >>> nor holding a spinlock. >>> The function mdelay in it can be replaced with msleep, to reduce busy wait. >>> >>> Signed-off-by: Jia-Ju Bai >> >> You submitted an identical patch a week earlier: >> >> https://patchwork.kernel.org/patch/10137671/ >> >> How is this different? Also always add version number to the patch so that the >> maintainers can follow the changes easily: >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing > > I had negative comments on one of those due to the possibility of > msleep(2) extending as long as 20 msec. Until the author, or someone > else, can test that this is OK, then the mdelay(2) can only be > replaced with usleep_range(2000, 3000). > > NACK for both. Ok, patches dropped. -- Kalle Valo