public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn-yOkvZcmFvRU@public.gmane.org>
To: Huajun Li <huajun.li.lee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
	Ming Lei <tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Alan Stern
	<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] usbnet: Activate the halt interrupt endpoint to fix endless "XactErr" error
Date: Mon, 11 Jun 2012 22:47:15 +0200	[thread overview]
Message-ID: <87sje1podo.fsf@nemi.mork.no> (raw)
In-Reply-To: <CA+v9cxaLERjFKdE7joGgmpbxCUotdh=Nn4F4f-KeOXwp8nqMPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (Huajun Li's message of "Mon, 11 Jun 2012 22:41:03 +0800")

Huajun Li <huajun.li.lee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

> diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h
> index 76f4396..c0bcb61 100644
> --- a/include/linux/usb/usbnet.h
> +++ b/include/linux/usb/usbnet.h
> @@ -62,13 +62,14 @@ struct usbnet {
>  	unsigned long		flags;
>  #		define EVENT_TX_HALT	0
>  #		define EVENT_RX_HALT	1
> -#		define EVENT_RX_MEMORY	2
> -#		define EVENT_STS_SPLIT	3
> -#		define EVENT_LINK_RESET	4
> -#		define EVENT_RX_PAUSED	5
> -#		define EVENT_DEV_WAKING 6
> -#		define EVENT_DEV_ASLEEP 7
> -#		define EVENT_DEV_OPEN	8
> +#		define EVENT_STS_HALT	2
> +#		define EVENT_RX_MEMORY	3
> +#		define EVENT_STS_SPLIT	4
> +#		define EVENT_LINK_RESET	5
> +#		define EVENT_RX_PAUSED	6
> +#		define EVENT_DEV_WAKING 7
> +#		define EVENT_DEV_ASLEEP 8
> +#		define EVENT_DEV_OPEN	9
>  };

Why do you renumber all of these instead of adding the new
EVENT_STS_HALT to the end of the list?


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2012-06-11 20:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05 14:12 [PATCH] usbnet: Activate the halt interrupt endpoint to fix endless "XactErr" error Huajun Li
2012-06-07 21:54 ` David Miller
2012-06-11 14:41   ` Huajun Li
     [not found]     ` <CA+v9cxaLERjFKdE7joGgmpbxCUotdh=Nn4F4f-KeOXwp8nqMPg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-11 20:47       ` Bjørn Mork [this message]
     [not found]         ` <87sje1podo.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2012-06-12 10:09           ` Huajun Li
     [not found] ` <CA+v9cxYHq4gcy11SDmsuHUhTSdLJM-G0sugYnOjSthbYWA+1Yg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-08  3:29   ` Ming Lei
     [not found]     ` <CACVXFVMwhoYyJHAsK0xF0poZxoZv8ENHhquPVAiGnsow5-FH8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-08  5:04       ` Huajun Li
2012-06-08  5:22         ` Ming Lei
     [not found]           ` <CACVXFVPj-4J2_UuOQ9NCW7wV_SLG50a-pEYqhd7K9sXuGmDmoQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-08  6:24             ` Huajun Li
     [not found]               ` <CA+v9cxbogzS7sVChqkRMgDUcs=aJgNDRH8ydoQ-_htfS2t52gQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-08 13:43                 ` Alan Stern
2012-06-08 15:24                   ` Huajun Li
     [not found]                     ` <CA+v9cxag9NV2ud+oupyziLN3nLgkgj+kyTcaOnEjYNjqXtM4Bw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-08 16:13                       ` Alan Stern
     [not found]                         ` <Pine.LNX.4.44L0.1206081212150.1360-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-06-08 16:36                           ` Huajun Li
2012-06-08 13:56               ` Ming Lei
2012-06-08 15:54                 ` Huajun Li
     [not found]                   ` <CACVXFVMGu2odRZdTRJo5_JDPMTMGWFy-NW+uLFnAqBO+3X=GJA@mail.gmail.com>
     [not found]                     ` <CA+v9cxZ6bDeNQ__tiPafiCau58dfvCgWmA1fbi_75uyySbtBAQ@mail.gmail.com>
     [not found]                       ` <CACVXFVPO+S5SPCzoyzCzjvh-wT4t2zh_naQ3GZ1B2fc9rmLJGw@mail.gmail.com>
     [not found]                         ` <CA+v9cxbd+PU--=o5T960fmOP1ZuxLc0+y1YgC_RLw-ivtZ8PRA@mail.gmail.com>
     [not found]                           ` <CACVXFVN4XB5V3N=CUpoN6Pcz7zVfQSoGQPQj508YnaueX1E3WA@mail.gmail.com>
     [not found]                             ` <CA+v9cxZd3W8BwWoxng0zPXe0-WA2pObre=Bjm4htJB_j-3YkJw@mail.gmail.com>
     [not found]                               ` <CA+v9cxZd3W8BwWoxng0zPXe0-WA2pObre=Bjm4htJB_j-3YkJw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-06-11  2:27                                 ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sje1podo.fsf@nemi.mork.no \
    --to=bjorn-yokvzcmfvru@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=huajun.li.lee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
    --cc=tom.leiming-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox