netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Li_Xin2@emc.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: TCP keepalive timer problem
Date: Thu, 27 Aug 2009 15:35:22 +0200	[thread overview]
Message-ID: <87skfdl6qt.fsf@basil.nowhere.org> (raw)
In-Reply-To: <4A967FCE.3000807@gmail.com> (Eric Dumazet's message of "Thu, 27 Aug 2009 14:45:02 +0200")

Eric Dumazet <eric.dumazet@gmail.com> writes:
>
> Now, 7200 seconds might be inappropriate for special needs, and considering
> there is no way to change tcp_retries2 for a given socket (only choice being the global
> tcp_retries2 setting), I would vote for a change in our stack, to *relax* RFC,
> and get smaller keepalive timers if possible.

I think the better fix would be to just to only do that when
tcp_retries2 > keep alive time. So keep the existing behaviour
with default keep alive, but switch when the user defined
a very short keep alive.

-Andi


-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2009-08-27 13:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0939B589FC103041945B9F13274963E303B1A9D4@CORPUSMX90A.corp.emc.com>
2009-08-25 13:13 ` TCP keepalive timer problem Eric Dumazet
2009-08-25 14:05   ` Li_Xin2
2009-08-27 12:45     ` Eric Dumazet
2009-08-27 13:35       ` Andi Kleen [this message]
2009-08-27 14:17         ` Eric Dumazet
2009-08-27 14:29           ` Andi Kleen
2009-08-27 14:49             ` Eric Dumazet
2009-08-28  1:55               ` Li_Xin2
2009-08-28  7:05                 ` Damian Lukowski
2009-08-25 14:04 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87skfdl6qt.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=Li_Xin2@emc.com \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).