From: Damien Wyart <damien.wyart@free.fr>
To: Auke Kok <auke-jan.h.kok@intel.com>
Cc: Daniel Walker <dwalker@mvista.com>, Andrew Morton <akpm@osdl.org>,
Jeff Garzik <jgarzik@pobox.com>,
linux-kernel@vger.kernel.org,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
NetDev <netdev@vger.kernel.org>
Subject: Re: [PATCH] e100_shutdown: netif_poll_disable hang
Date: Sat, 21 Oct 2006 19:41:15 +0200 [thread overview]
Message-ID: <87slhh1s90.fsf@brouette.noos.fr> (raw)
In-Reply-To: <45393B0B.8090301@intel.com> (Auke Kok's message of "Fri\, 20 Oct 2006 14\:09\:31 -0700")
> > > My machine annoyingly hangs while rebooting. I tracked it down to
> > > e100-fix-reboot-f-with-netconsole-enabled.patch in 2.6.18-rc2-mm2
> > > I review the changes and it seemed to be calling
> > > netif_poll_disable one too many time. Once in e100_down(), and
> > > again in e100_shutdown().
> > > The second one in e100_shutdown() caused the hang. So this patch
> > > removes it.
* Auke Kok <auke-jan.h.kok@intel.com> [061020 23:09]:
> it doesn't even do harm to netif_poll_disable() twice as far as I can
> see, as it merely calls test_and_set_bit(), which will instantly
> succeed on the first attempt if the bit was already set.
> did this change actually fix it for you? I'm wondering if the
> netif_carrier_off might not be the culprit here...
I can confirm the proposed original change of D. Walker fixed the
problem for me. I did not test the change you proposed as a followup.
--
Damien Wyart
next prev parent reply other threads:[~2006-10-21 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061020182820.978932000@mvista.com>
2006-10-20 20:51 ` [PATCH] e100_shutdown: netif_poll_disable hang Auke Kok
2006-10-20 21:09 ` Auke Kok
2006-10-21 17:41 ` Damien Wyart [this message]
2006-10-21 17:54 ` Auke Kok
2006-10-21 20:55 ` Damien Wyart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87slhh1s90.fsf@brouette.noos.fr \
--to=damien.wyart@free.fr \
--cc=akpm@osdl.org \
--cc=auke-jan.h.kok@intel.com \
--cc=dwalker@mvista.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).