From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sendmail.purelymail.com (sendmail.purelymail.com [34.202.193.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A2923EBF2A for ; Fri, 23 Jan 2026 20:05:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=34.202.193.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769198717; cv=none; b=NS5NKrs6TW31MrpWqH421saMicLuoNjcfJb+Qp2wSUQ67a5FQzxYaz5geeS+zMFIC/J6YC8a5L8cbqgp7QGh2eRjFxlLLEk8AsA73yysYuKFSMxqC8RdB+DXxje2oTut4HQCmPfy8lf0joRIk/6DmI7/Tqj08Woirh+DzXbGDzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769198717; c=relaxed/simple; bh=Q9QDlQYq8HcUocZzHDc81qU8oTuCskbFTBqYgKQ/GyI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ShWbFyjgobx8K0K3QwF+BMJHZ5FvfqBEqvL0Ev8oloxbY+2ar6+BB03TmAryK0zwoj3o6adg61izPvdhDS68kkGcqgVQ97jbCIXY4WgGVPCbYiWx8uEbUv9JYy8acjG7l96m2gMi6VDwJo0y2FBAub2R40ENT2IuEvtWUcbNbb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com; spf=pass smtp.mailfrom=korsgaard.com; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b=EGXXnIqN; arc=none smtp.client-ip=34.202.193.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=korsgaard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purelymail.com header.i=@purelymail.com header.b="EGXXnIqN" DKIM-Signature: a=rsa-sha256; b=EGXXnIqNf7p/NMmYROW5yQDoec8428yQIx6eX7KeILgvMUa6wAvl5a0p1ag6v8+Brd/0s1Os9JPJc+BQrAqvQ06aRiwFKjwLRQ+wHUfe+TaOEt58qb/d/9Q4TzygaRwga/N/ENqBDcytZtOE4ptu8iWZHmHthwSniqpnAXKdZRj9M6t+9Qk9PpdhdQBGom1+jj9mDwqvGxCbXyGbCTUzpjOxQO2MCYTm8RzC0lHwepcTF1vBWts8mbdXTLf9rZGJMohKhwFHd6X3dZmIPz4Na5sEry6cW+BmQTPwSVzdhnt7hJ63l+tAPAEhFHTTNCl+0TI+jkadVfZEB161wUXaFw==; s=purelymail1; d=purelymail.com; v=1; bh=Q9QDlQYq8HcUocZzHDc81qU8oTuCskbFTBqYgKQ/GyI=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 21632:4007:null:purelymail X-Pm-Original-To: netdev@vger.kernel.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1410584204; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 23 Jan 2026 20:04:55 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.98.2) (envelope-from ) id 1vjNOo-0000000FoVT-16Ny; Fri, 23 Jan 2026 21:04:54 +0100 From: Peter Korsgaard To: Ethan Nelson-Moore Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Subject: Re: [PATCH net-next] net: usb: sr9700: use ETH_ALEN instead of magic number In-Reply-To: <20260123070645.56434-1-enelsonmoore@gmail.com> (Ethan Nelson-Moore's message of "Thu, 22 Jan 2026 23:06:39 -0800") References: <20260123070645.56434-1-enelsonmoore@gmail.com> Date: Fri, 23 Jan 2026 21:04:54 +0100 Message-ID: <87tswcrt7d.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain >>>>> "Ethan" == Ethan Nelson-Moore writes: > The driver hardcodes the number 6 as the number of bytes to write to > the SR_PAR register, which stores the MAC address. Use ETH_ALEN instead > to make the code clearer. > Signed-off-by: Ethan Nelson-Moore Reviewed-by: Peter Korsgaard -- Bye, Peter Korsgaard