From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tariq Toukan <tariqt@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>,
Simon Horman <horms@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH net-next 3/5] ethtool: add interface to read representor Rx statistics
Date: Fri, 05 Apr 2024 22:25:21 -0700 [thread overview]
Message-ID: <87ttkf2h71.fsf@nvidia.com> (raw)
In-Reply-To: <20240405215335.7a5601ca@kernel.org>
On Fri, 05 Apr, 2024 21:53:35 -0700 Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu, 4 Apr 2024 20:33:55 +0300 Tariq Toukan wrote:
>> +/**
>> + * struct ethtool_rep_port_stats - representor port statistics
>> + * @rep_port_stats: struct group for representor port
>
> In more trivial remarks - kernel-doc script apparently doesn't want
> the group to be documented (any more?)
>
I took a look, and I believe the behavior of kernel-doc has remained the
same since the struct_group() helper macro was introduced. That said, I
think allowing the documentation of struct_group() would be a reasonable
choice/maybe worth updating the script.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=50d7bd38c3aafc4749e05e8d7fcb616979143602
>> + * @out_of_buf: Number of packets were dropped due to buffer exhaustion.
>> + */
>> +struct ethtool_rep_port_stats {
>> + struct_group(rep_port_stats,
>> + u64 out_of_buf;
>> + );
>> +};
>> +
next prev parent reply other threads:[~2024-04-06 5:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 17:33 [PATCH net-next 0/5] mlx5e rc2 misc patches Tariq Toukan
2024-04-04 17:33 ` [PATCH net-next 1/5] net/mlx5e: Extract checking of FEC support for a link mode Tariq Toukan
2024-04-04 17:33 ` [PATCH net-next 2/5] net/mlx5e: Support FEC settings for 100G/lane modes Tariq Toukan
2024-04-04 17:33 ` [PATCH net-next 3/5] ethtool: add interface to read representor Rx statistics Tariq Toukan
2024-04-06 4:53 ` Jakub Kicinski
2024-04-06 5:25 ` Rahul Rameshbabu [this message]
2024-04-06 5:46 ` Jakub Kicinski
2024-04-04 17:33 ` [PATCH net-next 4/5] net/mlx5e: Expose the VF/SF RX drop counter on the representor Tariq Toukan
2024-04-04 17:33 ` [PATCH net-next 5/5] net/mlx5e: Un-expose functions in en.h Tariq Toukan
2024-04-05 5:53 ` Kalesh Anakkur Purayil
2024-04-06 4:56 ` [PATCH net-next 0/5] mlx5e rc2 misc patches Jakub Kicinski
2024-04-06 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttkf2h71.fsf@nvidia.com \
--to=rrameshbabu@nvidia.com \
--cc=cjubran@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).