Re: [PATCH net] net: stmmac: Fix EST offset for dwmac 5.10

Kurt Kanzenbach
2024-02-20T09:45:00Z

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

On Tue Feb 20 2024, Serge Semin wrote:
> Hi Kurt
>
> On Tue, Feb 20, 2024 at 09:22:46AM +0100, Kurt Kanzenbach wrote:
>> Fix EST offset for dwmac 5.10.
>>
>> Currently configuring Qbv doesn't work as expected. The schedule is
>> configured, but never confirmed:
>>
>> |[ 128.250219] imx-dwmac 428a0000.ethernet eth1: configured EST
>>
>> The reason seems to be the refactoring of the EST code which set the wrong
>> EST offset for the dwmac 5.10. After fixing this it works as before:
>>
>> |[ 106.359577] imx-dwmac 428a0000.ethernet eth1: configured EST
>> |[ 128.430715] imx-dwmac 428a0000.ethernet eth1: EST: SWOL has been switched
>>
>> Tested on imx93.
>>
>> Fixes: c3f3b97238f6 ("net: stmmac: Refactor EST implementation")
>> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/hwif.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> index 1bd34b2a47e8..29367105df54 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> @@ -224,7 +224,7 @@ static const struct stmmac_hwif_entry {
>> .regs = {
>> .ptp_off = PTP_GMAC4_OFFSET,
>> .mmc_off = MMC_GMAC4_OFFSET,
>> - .est_off = EST_XGMAC_OFFSET,
>> + .est_off = EST_GMAC4_OFFSET,
>
> Unfortunate c&p typo indeed. Thanks for fixing it!

No problem. I was just wondering why the confirmation message doesn't
show up after updating to v6.8-RT :-).

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]