netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Machata <petrm@nvidia.com>
To: Andrea Claudi <aclaudi@redhat.com>
Cc: <netdev@vger.kernel.org>, Leon Romanovsky <leon@kernel.org>,
	Jiri Pirko <jiri@resnulli.us>, Jon Maloy <jmaloy@redhat.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH iproute2 1/2] docs, man: fix some typos
Date: Wed, 10 Jan 2024 11:35:38 +0100	[thread overview]
Message-ID: <87ttnlo3vh.fsf@nvidia.com> (raw)
In-Reply-To: <cda844f5f7fe512ca9b7f87a6545157394b9d9ae.1704816744.git.aclaudi@redhat.com>


Andrea Claudi <aclaudi@redhat.com> writes:

> Fix some typos and spelling errors in iproute2 documentation.
>
> Signed-off-by: Andrea Claudi <aclaudi@redhat.com>

Reviewed-by: Petr Machata <petrm@nvidia.com>

> --- a/doc/actions/actions-general
> +++ b/doc/actions/actions-general
> @@ -116,7 +116,7 @@ The script below does the following:
>  - If it does exceed its rate, its "color" changes to a mark of 2 and it is
>  then passed through a second meter.
>  
> --The second meter is shared across all flows on that device [i am surpised
> +-The second meter is shared across all flows on that device [i am surprised
>  that this seems to be not a well know feature of the policer; Bert was telling
>  me that someone was writing a qdisc just to do sharing across multiple devices;
>  it must be the summer heat again; weve had someone doing that every year around

This document reads more like a newsgroup article or something from a
zine than a formal piece of documentation. Even in this excerpt we see
an uncapitalized "i" and a "weve", and there are many issues like this
elsewhere. Fixing it feels a bit futile, plus I kinda like the
slice-of-history nature of the document :) But yeah, the fix is correct.

  reply	other threads:[~2024-01-10 10:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 16:32 [PATCH iproute2 0/2] Fix some more typos in docs and comments Andrea Claudi
2024-01-09 16:32 ` [PATCH iproute2 1/2] docs, man: fix some typos Andrea Claudi
2024-01-10 10:35   ` Petr Machata [this message]
2024-01-11 17:21   ` Stephen Hemminger
2024-01-11 19:39   ` Stephen Hemminger
2024-01-09 16:32 ` [PATCH iproute2 2/2] treewide: fix typos in various comments Andrea Claudi
2024-01-10 10:54   ` Petr Machata
2024-01-11 19:40   ` Stephen Hemminger
2024-01-12 11:23     ` Andrea Claudi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttnlo3vh.fsf@nvidia.com \
    --to=petrm@nvidia.com \
    --cc=aclaudi@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=jmaloy@redhat.com \
    --cc=leon@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).