[PATCH] iproute2: prevent memory leak on error return

[PATCH] iproute2: prevent memory leak on error return

[heminhong]

When rtnl_statsdump_req_filter() or rtnl_dump_filter() failed to process,
just return will cause memory leak.

Signed-off-by: heminhong <heminhong@kylinos.cn>
---
 ip/iplink.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ip/iplink.c b/ip/iplink.c
index 9a548dd3..c7e5021c 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -1722,11 +1722,13 @@ static int iplink_afstats(int argc, char **argv)
 	if (rtnl_statsdump_req_filter(&rth, AF_UNSPEC, filt_mask,
 				      NULL, NULL) < 0) {
 		perror("Cannont send dump request");
+		delete_json_obj();
 		return 1;
 	}
 
 	if (rtnl_dump_filter(&rth, print_af_stats, &ctx) < 0) {
 		fprintf(stderr, "Dump terminated\n");
+		delete_json_obj();
 		return 1;
 	}
 
-- 
2.25.1

Re: [PATCH] iproute2: prevent memory leak on error return

[Petr Machata]

heminhong <heminhong@kylinos.cn> writes:

> When rtnl_statsdump_req_filter() or rtnl_dump_filter() failed to process,
> just return will cause memory leak.
>
> Signed-off-by: heminhong <heminhong@kylinos.cn>

Reviewed-by: Petr Machata <petrm@nvidia.com>

Re: [PATCH] iproute2: prevent memory leak on error return

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Tue, 14 Nov 2023 16:13:07 +0800 you wrote:
> When rtnl_statsdump_req_filter() or rtnl_dump_filter() failed to process,
> just return will cause memory leak.
> 
> Signed-off-by: heminhong <heminhong@kylinos.cn>
> ---
>  ip/iplink.c | 2 ++
>  1 file changed, 2 insertions(+)

Here is the summary with links:
  - iproute2: prevent memory leak on error return
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=389657c3ec43

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html