From: Kalle Valo <kvalo@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] wifi: mt7601u: update firmware path
Date: Wed, 24 May 2023 10:47:21 +0300 [thread overview]
Message-ID: <87ttw2kw6u.fsf@kernel.org> (raw)
In-Reply-To: <87o7mkn91f.fsf@kernel.org> (Kalle Valo's message of "Tue, 16 May 2023 08:24:12 +0300")
Kalle Valo <kvalo@kernel.org> writes:
> Daniel Golle <daniel@makrotopia.org> writes:
>
>> mt7601u.bin was moved to mediatek/ folder in linux-wireless via commit
>> 8451c2b1 ("mt76xx: Move the old Mediatek WiFi firmware to mediatek")
>> and linux-firmware release 20230515.
>
> Why was it moved?
Here's the link to the commit in linux-firmware:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=8451c2b1d529dc1a49328ac9235d3cf5bb8a8fcb
It would be good to include that in the commit log. Unfortunately the
linux-firmware commit doesn't explain why the change is made, oh well.
>> --- a/drivers/net/wireless/mediatek/mt7601u/usb.h
>> +++ b/drivers/net/wireless/mediatek/mt7601u/usb.h
>> @@ -8,7 +8,7 @@
>>
>> #include "mt7601u.h"
>>
>> -#define MT7601U_FIRMWARE "mt7601u.bin"
>> +#define MT7601U_FIRMWARE "mediatek/mt7601u.bin"
>
> How do we handle backwards compatibility? We have a rule that old
> userspace needs to work with new kernel and this change breaks that.
Luckily the linux-firmware commit added symlinks so that won't break the
backward compatibility. But I think in the driver we still need to
support both the old and new location for several years. So the driver
should first try the new location, next the old location and only after
that fail.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-05-24 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 22:56 [PATCH] wifi: mt7601u: update firmware path Daniel Golle
2023-05-16 5:24 ` Kalle Valo
2023-05-24 7:47 ` Kalle Valo [this message]
2023-05-16 10:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttw2kw6u.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).