From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 885CABE73 for ; Wed, 24 May 2023 07:47:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2144C433EF; Wed, 24 May 2023 07:47:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684914446; bh=KhQ0blVR5cXlzUR6vdxYF+zuuLth0MWzdADoCBQqa44=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=pLpUbESyZfGpmf0GKjmrfiv0HHs77Na8zqN6Wm0A4OWoRIqWT/PyZufb9YZz4NZWC Ak2xLnl8NWJfwuYnjB8LEZBwoCQw16eHDK1JYar9J+uOnj3AoTwLrZalzcX7Vfj/Sp 8aRkeCka6sTbv9VltyPUCMqe6jrev4TDqj1FLNzLThHZZyawLZJbU4rVjakc3TR5Bo 6S4U+EXpcQbuvBM8Xehrfa8zzvdAQhrGijsGP2zEYHbTcOsWUt/0BOK6Foz9RkShS6 WmcvuYcrck/2xnpHctbegwgKwNi+n0peoHIi/UNq+8g6zb3udU5seVDMXa9wW3UtMh qOR899x8zbmzg== From: Kalle Valo To: Daniel Golle Cc: Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] wifi: mt7601u: update firmware path References: <87o7mkn91f.fsf@kernel.org> Date: Wed, 24 May 2023 10:47:21 +0300 In-Reply-To: <87o7mkn91f.fsf@kernel.org> (Kalle Valo's message of "Tue, 16 May 2023 08:24:12 +0300") Message-ID: <87ttw2kw6u.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Kalle Valo writes: > Daniel Golle writes: > >> mt7601u.bin was moved to mediatek/ folder in linux-wireless via commit >> 8451c2b1 ("mt76xx: Move the old Mediatek WiFi firmware to mediatek") >> and linux-firmware release 20230515. > > Why was it moved? Here's the link to the commit in linux-firmware: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=8451c2b1d529dc1a49328ac9235d3cf5bb8a8fcb It would be good to include that in the commit log. Unfortunately the linux-firmware commit doesn't explain why the change is made, oh well. >> --- a/drivers/net/wireless/mediatek/mt7601u/usb.h >> +++ b/drivers/net/wireless/mediatek/mt7601u/usb.h >> @@ -8,7 +8,7 @@ >> >> #include "mt7601u.h" >> >> -#define MT7601U_FIRMWARE "mt7601u.bin" >> +#define MT7601U_FIRMWARE "mediatek/mt7601u.bin" > > How do we handle backwards compatibility? We have a rule that old > userspace needs to work with new kernel and this change breaks that. Luckily the linux-firmware commit added symlinks so that won't break the backward compatibility. But I think in the driver we still need to support both the old and new location for several years. So the driver should first try the new location, next the old location and only after that fail. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches