From: Kalle Valo <kvalo@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Johannes Berg <johannes.berg@intel.com>,
Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
Wen Gong <quic_wgong@quicinc.com>,
Baochen Qiang <quic_bqiang@quicinc.com>,
Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ath12k@lists.infradead.org
Subject: Re: [PATCH] wireless: ath: work around false-positive stringop-overread warning
Date: Mon, 08 May 2023 11:44:44 +0300 [thread overview]
Message-ID: <87ttwnnrer.fsf@kernel.org> (raw)
In-Reply-To: <20230417205447.1800912-1-arnd@kernel.org> (Arnd Bergmann's message of "Mon, 17 Apr 2023 22:54:20 +0200")
Arnd Bergmann <arnd@kernel.org> writes:
> From: Arnd Bergmann <arnd@arndb.de>
>
> In a rare arm64 randconfig build, I got multiple warnings for ath11k
> and ath12k:
>
> In function 'ath11k_peer_assoc_h_ht',
> inlined from 'ath11k_peer_assoc_prepare' at drivers/net/wireless/ath/ath11k/mac.c:2665:2:
> drivers/net/wireless/ath/ath11k/mac.c:1709:13: error: 'ath11k_peer_assoc_h_ht_masked' reading 10 bytes from a region of size 0 [-Werror=stringop-overread]
> 1709 | if (ath11k_peer_assoc_h_ht_masked(ht_mcs_mask))
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> This happens whenever gcc-13 fails to inline one of the functions
> that take a fixed-length array argument but gets passed a pointer.
>
> Change these functions to all take a regular pointer argument
> instead.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
s/wireless:/wifi:/ but I can fix that.
In a awat it's a shame to lose the explicit length but I guess there's
no other way to fix this?
Also I hope you find the time to add GCC 13 to crosstool :) Related to
this, last year we had a similar warning with GCC 11 for which I added this
not-so-pretty workaround:
abf93f369419 wifi: ath11k: mac: fix reading 16 bytes from a region of size 0 warning
https://git.kernel.org/linus/abf93f369419
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-05-08 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 20:54 [PATCH] wireless: ath: work around false-positive stringop-overread warning Arnd Bergmann
2023-04-20 14:04 ` Simon Horman
2023-05-08 8:44 ` Kalle Valo [this message]
2023-05-08 8:52 ` Arnd Bergmann
2023-05-08 14:57 ` Kalle Valo
2023-05-08 15:07 ` Arnd Bergmann
2023-05-08 19:19 ` Kalle Valo
2023-06-03 7:43 ` Arnd Bergmann
2023-06-05 13:06 ` Kalle Valo
2023-05-09 16:48 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttwnnrer.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_bqiang@quicinc.com \
--cc=quic_mpubbise@quicinc.com \
--cc=quic_ssreeela@quicinc.com \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).