From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 044C1C7618E for ; Thu, 20 Apr 2023 22:38:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232869AbjDTWiZ (ORCPT ); Thu, 20 Apr 2023 18:38:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231302AbjDTWiY (ORCPT ); Thu, 20 Apr 2023 18:38:24 -0400 Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22C2B3C07; Thu, 20 Apr 2023 15:38:23 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1682030301; bh=RROvBsZouizJZbT/+MfyL7hKGqy3iT9UJY9igD8NDzw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Iy9/XFF+Awcyj4f+sJGX2vESbkpe64jr7xETrPXZPVoyPLLIU+k8209adYxvP1lWz 4oCCeZNArJikadqyTkQDg5nY94142ezE/m/b00OtLfvLCUowEet2ekMgBrDosfawuO zc0IEOtEiNA8WWahd/WC4P/BTJ0fk7uzYVWc7GQwkfLExz0zcHYWsilKBGC5A3qMFO hK56A9351YyjsCqFJ02KXMr8TAxbNWJE6kx85w5er2ue+fzTl14ED+maskqNLbplqR kYvvK7yOQle66mQWcluKK9mmhMbhgtO5W0VwUP5Zl55uVEJrYxVgttK4m08RqErBPt em5SaA/mmLpdA== To: Linus Torvalds Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Colin Ian King , Thorsten Leemhuis , Jakub Kicinski , Kalle Valo , Linux kernel regressions list Subject: Re: One-off regression fix for 6.3 [was: Re: [PATCH] wifi: ath9k: Don't mark channelmap stack variable read-only in ath9k_mci_update_wlan_channels()] In-Reply-To: References: <20230413214118.153781-1-toke@toke.dk> <87zg72s1jz.fsf@toke.dk> Date: Fri, 21 Apr 2023 00:38:19 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87ttxarxgk.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Linus Torvalds writes: > On Thu, Apr 20, 2023 at 2:09=E2=80=AFPM Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >> >> So, with a bit of prodding from Thorsten, I'm writing this to ask you if >> you'd be willing to pull this patch directly from the mailing list as a >> one-off? It's a fairly small patch, and since it's a (partial) revert >> the risk of it being the cause of new regressions should be fairly >> small. > > Sure. I'm always open to direct fixes when there is no controversy > about the fix. No problem. I still happily deal with individual > patches. Awesome, thanks! > And yes, I do consider "regression in an earlier release" to be a > regression that needs fixing. > > There's obviously a time limit: if that "regression in an earlier > release" was a year or more ago, and just took forever for people to > notice, and it had semantic changes that now mean that fixing the > regression could cause a _new_ regression, then that can cause me to > go "Oh, now the new semantics are what we have to live with". > > But something like this, where the regression was in the previous > release and it's just a clear fix with no semantic subtlety, I > consider to be just a regular regression that should be expedited - > partly to make it into stable, and partly to avoid having to put the > fix into _another_ stable kernel.. OK, duly noted; thank you for clarifying :) -Toke