Re: [PATCH v2 net 3/3] mtk_sgmii: enable PCS polling to allow SFP work

["Bjørn Mork" <bjorn@mork.no>]

"Russell King (Oracle)" <linux@armlinux.org.uk> writes:
> On Fri, Jan 20, 2023 at 11:49:47AM +0100, Bjørn Mork wrote:
>> From: Alexander Couzens <lynxis@fe80.eu>
>> 
>> Currently there is no IRQ handling (even the SGMII supports it).
>> Enable polling to support SFP ports.
>> 
>> Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
>> Signed-off-bu: Bjørn Mork <bjorn@mork.no>
>
> Typo in this attributation.

Impressive!  Thanks.

I tend to forget the -s when doing anything but "git commit" (and this
came from "git am").  And then I try to fix it manually.  Forgetting
that I'm unable to type a three-letter word with less than four errors.

A bit surprised checkpatch didn't catch it.  I guess it's happy with one
SoB, and silently accepting all unknown tags.

>> ---
>>  drivers/net/ethernet/mediatek/mtk_sgmii.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/net/ethernet/mediatek/mtk_sgmii.c b/drivers/net/ethernet/mediatek/mtk_sgmii.c
>> index c4261069b521..24ea541bf7d7 100644
>> --- a/drivers/net/ethernet/mediatek/mtk_sgmii.c
>> +++ b/drivers/net/ethernet/mediatek/mtk_sgmii.c
>> @@ -187,6 +187,7 @@ int mtk_sgmii_init(struct mtk_sgmii *ss, struct device_node *r, u32 ana_rgc3)
>>  			return PTR_ERR(ss->pcs[i].regmap);
>>  
>>  		ss->pcs[i].pcs.ops = &mtk_pcs_ops;
>> +		ss->pcs[i].pcs.poll = 1;
>
> As "poll" is a bool, we prefer true/false rather than 1/0. Using
> 1/0 will probably cause someone to submit a patch changing this, so
> it's probably best to fix this up at submission time.

Yes. Will fix.


Bjørn