From: Kalle Valo <kvalo@kernel.org>
To: Aaron Ma <aaron.ma@canonical.com>
Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com,
shayne.chen@mediatek.com, sean.wang@mediatek.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, matthias.bgg@gmail.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: mt76: mt7921: fix error code of return in mt7921_acpi_read
Date: Mon, 16 Jan 2023 17:41:39 +0200 [thread overview]
Message-ID: <87tu0qxz9o.fsf@kernel.org> (raw)
In-Reply-To: <20230116152235.1433484-1-aaron.ma@canonical.com> (Aaron Ma's message of "Mon, 16 Jan 2023 23:22:35 +0800")
Aaron Ma <aaron.ma@canonical.com> writes:
> Kernel NULL pointer dereference when ACPI SAR table isn't implemented well.
> Fix the error code of return to mark the ACPI SAR table as invalid.
>
> [ 5.077128] mt7921e 0000:06:00.0: sar cnt = 0
> [ 5.077381] BUG: kernel NULL pointer dereference, address:
> 0000000000000004
> [ 5.077630] #PF: supervisor read access in kernel mode
> [ 5.077883] #PF: error_code(0x0000) - not-present page
> [ 5.078138] PGD 0 P4D 0
> [ 5.078398] Oops: 0000 [#1] PREEMPT SMP NOPTI
> [ 5.079202] RIP: 0010:mt7921_init_acpi_sar+0x106/0x220
> [mt7921_common]
> ...
> [ 5.080786] Call Trace:
> [ 5.080786] <TASK>
> [ 5.080786] mt7921_register_device+0x37d/0x490 [mt7921_common]
> [ 5.080786] mt7921_pci_probe.part.0+0x2ee/0x310 [mt7921e]
> [ 5.080786] mt7921_pci_probe+0x52/0x70 [mt7921e]
> [ 5.080786] local_pci_probe+0x47/0x90
> [ 5.080786] pci_call_probe+0x55/0x190
> [ 5.080786] pci_device_probe+0x84/0x120
>
> Fixes: f965333e491e ("mt76: mt7921: introduce ACPI SAR support")
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
Felix, if this is ok should this go to v6.2?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-01-16 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 15:22 [PATCH] wifi: mt76: mt7921: fix error code of return in mt7921_acpi_read Aaron Ma
2023-01-16 15:41 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu0qxz9o.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=aaron.ma@canonical.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).