From: Kalle Valo <kvalo@kernel.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Jakub Kicinski <kuba@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-wireless@vger.kernel.org, Neo Jou <neojou@gmail.com>,
Hans Ulli Kroll <linux@ulli-kroll.de>,
Ping-Ke Shih <pkshih@realtek.com>,
Yan-Hsuan Chuang <tony0620emma@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
kernel@pengutronix.de, Johannes Berg <johannes@sipsolutions.net>,
Alexander Hochbaum <alex@appudo.com>, Da Xue <da@libre.computer>,
Po-Hao Huang <phhuang@realtek.com>,
Viktor Petrenko <g0000ga@gmail.com>
Subject: Re: [PATCH v4 08/11] wifi: rtw88: Add rtw8821cu chipset support
Date: Thu, 08 Dec 2022 16:21:16 +0200 [thread overview]
Message-ID: <87tu260yeb.fsf@kernel.org> (raw)
In-Reply-To: <d2113f20-d547-ce16-ff7f-2d1286321014@lwfinger.net> (Larry Finger's message of "Tue, 29 Nov 2022 10:59:46 -0600")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 11/29/22 10:17, Jakub Kicinski wrote:
>> On Tue, 29 Nov 2022 11:07:51 +0100 Sascha Hauer wrote:
>>> +config RTW88_8821CU
>>> + tristate "Realtek 8821CU USB wireless network adapter"
>>> + depends on USB
>>> + select RTW88_CORE
>>> + select RTW88_USB
>>> + select RTW88_8821C
>>> + help
>>> + Select this option will enable support for 8821CU chipset
>>> +
>>> + 802.11ac USB wireless network adapter
>>
>> Those kconfig knobs add so little code, why not combine them all into
>> one? No point bothering the user with 4 different questions with amount
>> to almost nothing.
>
> I see only one knob there, name RTW88_8821CU. The other configuration
> variables select parts of the code that are shared with other drivers
> such as RTW88_8821CE and these parts must be there.
I just test compiled these patches and we have four new questions:
Realtek 8822BU USB wireless network adapter (RTW88_8822BU) [N/m/?] (NEW) m
Realtek 8822CU USB wireless network adapter (RTW88_8822CU) [N/m/?] (NEW) m
Realtek 8723DU USB wireless network adapter (RTW88_8723DU) [N/m/?] (NEW) m
Realtek 8821CU USB wireless network adapter (RTW88_8821CU) [N/m/?] (NEW)
To me this looks too fine grained. Does it really make sense, for
example, to enable RTW88_8822BU but not RTW88_8822CU? Would just having
RTW88_USB containing all USB devices be more sensible? And the same for
PCI, and if we have in the future, SDIO devices.
But like discussed earlier, to keep things simple let's handle that
separately from this patchset.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-12-08 14:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 10:07 [PATCH v4 00/11] RTW88: Add support for USB variants Sascha Hauer
2022-11-29 10:07 ` [PATCH v4 01/11] wifi: rtw88: print firmware type in info message Sascha Hauer
2022-11-29 10:07 ` [PATCH v4 02/11] wifi: rtw88: Call rtw_fw_beacon_filter_config() with rtwdev->mutex held Sascha Hauer
2022-11-29 10:07 ` [PATCH v4 03/11] wifi: rtw88: Drop rf_lock Sascha Hauer
2022-11-29 10:07 ` [PATCH v4 04/11] wifi: rtw88: Drop h2c.lock Sascha Hauer
2022-11-29 10:07 ` [PATCH v4 05/11] wifi: rtw88: Drop coex mutex Sascha Hauer
2022-11-29 10:07 ` [PATCH v4 06/11] wifi: rtw88: iterate over vif/sta list non-atomically Sascha Hauer
2022-11-29 10:07 ` [PATCH v4 07/11] wifi: rtw88: Add common USB chip support Sascha Hauer
2022-11-30 1:40 ` Ping-Ke Shih
2022-11-30 8:13 ` Sascha Hauer
2022-11-30 8:35 ` Ping-Ke Shih
2022-11-29 10:07 ` [PATCH v4 08/11] wifi: rtw88: Add rtw8821cu chipset support Sascha Hauer
2022-11-29 16:17 ` Jakub Kicinski
2022-11-29 16:59 ` Larry Finger
2022-12-08 14:21 ` Kalle Valo [this message]
2022-12-09 3:17 ` Ping-Ke Shih
2022-12-02 8:09 ` Sascha Hauer
2022-12-02 12:36 ` Kalle Valo
2022-11-29 10:07 ` [PATCH v4 09/11] wifi: rtw88: Add rtw8822bu " Sascha Hauer
2022-11-29 10:07 ` [PATCH v4 10/11] wifi: rtw88: Add rtw8822cu " Sascha Hauer
2022-11-29 10:07 ` [PATCH v4 11/11] wifi: rtw88: Add rtw8723du " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu260yeb.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Larry.Finger@lwfinger.net \
--cc=alex@appudo.com \
--cc=da@libre.computer \
--cc=g0000ga@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@ulli-kroll.de \
--cc=martin.blumenstingl@googlemail.com \
--cc=neojou@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=pkshih@realtek.com \
--cc=s.hauer@pengutronix.de \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).