netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH iproute2] Fix segv on "-r" option if unknown rpc service
Date: Sun, 18 Sep 2022 02:50:54 +0900	[thread overview]
Message-ID: <87tu55q48x.fsf@mail.parknet.co.jp> (raw)

In init_service_resolver(), if getrpcbynumber() returned NULL, c->name
is pointing the undefined memory. So "-r" can segv for example.

So this patch uses "rpc.<r_prog>" format like the following if rpc
name is unresolved, instead of segv or raw port number.

	tcp   LISTEN  0  64  0.0.0.0:rpc.100227  0.0.0.0:*

[Or we would be able to set c->name = NULL to use raw port number]

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
 misc/ss.c |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/misc/ss.c b/misc/ss.c
index ff985cd..866e278 100644
--- a/misc/ss.c	2022-08-25 16:22:06.454913793 +0900
+++ b/misc/ss.c	2022-09-18 02:48:24.212779850 +0900
@@ -1596,6 +1596,15 @@ static void init_service_resolver(void)
 		if (rpc) {
 			strncat(prog, rpc->r_name, 128 - strlen(prog));
 			c->name = strdup(prog);
+		} else {
+			const char fmt[] = "%s%u";
+			char *buf = NULL;
+			int len = snprintf(buf, 0, fmt, prog,
+					   rhead->rpcb_map.r_prog);
+			len++;
+			buf = malloc(len);
+			snprintf(buf, len, fmt, prog, rhead->rpcb_map.r_prog);
+			c->name = buf;
 		}
 
 		c->next = rlist;
_

-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

             reply	other threads:[~2022-09-17 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-17 17:50 OGAWA Hirofumi [this message]
2022-09-22 19:01 ` [PATCH iproute2] Fix segv on "-r" option if unknown rpc service Stephen Hemminger
2022-09-22 20:31   ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu55q48x.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).