On Fri Aug 19 2022, Vladimir Oltean wrote: > Hi Kurt, > > On Fri, Aug 19, 2022 at 10:16:20AM +0200, Kurt Kanzenbach wrote: >> On Wed Aug 17 2022, Vladimir Oltean wrote: >> > Vinicius' progress on upstreaming frame preemption support for Intel I226 >> > seemed to stall, so I decided to give it a go using my own view as well. >> > https://patchwork.kernel.org/project/netdevbpf/cover/20220520011538.1098888-1-vinicius.gomes@intel.com/ >> >> Great to see progress on FPE :-). > > Let's hope it lasts ;) > >> > - Finally, the hardware I'm working with (here, the test vehicle is the >> > NXP ENETC from LS1028A, although I have patches for the Felix switch >> > as well, but those need a bit of a revolution in the driver to go in >> > first). This hardware is not without its flaws, but at least allows me >> > to concentrate on the UAPI portions for this series. >> > >> > I also have a kselftest written, but it's for the Felix switch (covers >> > forwarding latency) and so it's not included here. >> >> What kind of selftest did you implement? So far I've been doing this: >> Using a cyclic real time application to create high priority frames and >> running iperf3 in parallel to simulate low priority traffic >> constantly. Afterwards, checking the NIC statistics for fragments and so >> on. Also checking the latency of the RT frames with FPE on/off. >> >> BTW, if you guys need help with testing of patches, i do have access to >> i225 and stmmacs which both support FPE. Also the Hirschmann switches >> should support it. > > Blah, I didn't want to spoil the surprise just yet. I am orchestrating 2 > isochron senders at specific times, one of PT traffic and one of ET. > > There are actually 2 variants of this: one is for endpoint FP and the > other is for bridge FP. I only had time to convert the bridge FP to > kselftest format; not the endpoint one (for enetc). > > In the endpoint case, interference is created on the sender interface. > I compare HW TX timestamps to the expected TX times to calculate how > long it took until PT was preempted. I repeat the test millions of times > until I can plot the latencies having the PT <-> ET base time offset on > the X axis. It looks very cool. > > The bridge case is similar, except for the fact that interference is > created on a bridge port going to a common receiver of 2 isochron > senders. What I plot is the path delay, and again, this shows actual > preemption times with a nanosecond resolution. That makes a lot of sense and this kind of test scenario should work for other endpoints implementations such as igc and stmmac too. Thanks, Kurt