From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9592FC3524D for ; Mon, 3 Feb 2020 20:45:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69F1E20721 for ; Mon, 3 Feb 2020 20:45:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EBYj6p0r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727080AbgBCUpZ (ORCPT ); Mon, 3 Feb 2020 15:45:25 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:36505 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726278AbgBCUpZ (ORCPT ); Mon, 3 Feb 2020 15:45:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580762723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9rBeREEFrc1ibiywC0oSftvsLzox1ImW/OL6dossCxk=; b=EBYj6p0r0hfppSbARuyzGhnO24iU5+atmGlmowkZ+mj6FPN5piZEGJ2K3w72stGJRIs5RN Jy5ZnC/yERSMvK4iXCJwXQAqfB/9BmUkBg8SvRFcgnJ3//rlLWmqjS75gsB/ZqXW4OGsuH zV5A3SwN3UbnSi30y1Zi0PLYNO5NGUA= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-DihBX3yyOTSZbjTC-v9KVw-1; Mon, 03 Feb 2020 15:45:21 -0500 X-MC-Unique: DihBX3yyOTSZbjTC-v9KVw-1 Received: by mail-lj1-f200.google.com with SMTP id z2so4404628ljh.16 for ; Mon, 03 Feb 2020 12:45:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=9rBeREEFrc1ibiywC0oSftvsLzox1ImW/OL6dossCxk=; b=rrhhVl1oxD5ysLpvmm3NiXfsRikS+3vwNKPE/eG/zdxlGr+VV5WvZFVypaJL+p5RHB hyzuOB3qqcq3HEPND2dQyyW0/33eVuSiPDRPhV9A6bj0oPwG1+r2Ail4i8ZypLobWHcT iQV6NO7cwHOegA6EfmpkEApyeUyo1bTwVkC3b40QpUmodtHvdrYrGcBqxDQwCNB10pBL KIQmQZcj/5P+b6k89ANKVc3aACD9R2n0iKbIbNtvPPkrP740hrd/p8YDKdH+2x+Wl6Gn XnGjDp/SyAbYJQRpvmVxwgYbFFTlYSQULAXIZYi4xN999IcPjlAf9McqPi+MjK99x8ds alQw== X-Gm-Message-State: APjAAAX1MU2dc69fTpuGkly34GbH5V64gQPJ2P0t/mD/ySz26pvmeJxy pEZpcRDkVY34Mk70A1Xttk1fKXMrgG/k3p72OxJSX205CznxM8+ym5K0cVv57c6upPSuAZ/11Pi +Zfu8/EU15dcgxakF X-Received: by 2002:a2e:810d:: with SMTP id d13mr14964347ljg.113.1580762720043; Mon, 03 Feb 2020 12:45:20 -0800 (PST) X-Google-Smtp-Source: APXvYqxAS4HyP3obPp8U0dyuNGHmzCDo/fMPU55pFRDiI0nn2BEQ1igI8sTBIhJDPBTFIzM1H+QORw== X-Received: by 2002:a2e:810d:: with SMTP id d13mr14964331ljg.113.1580762719872; Mon, 03 Feb 2020 12:45:19 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id v16sm9488227lfp.92.2020.02.03.12.45.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 12:45:18 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id D12A81800A2; Mon, 3 Feb 2020 21:45:17 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Jiri Olsa Cc: Alexei Starovoitov , Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org, bpf@vger.kernel.org, Andrii Nakryiko , Yonghong Song , Martin KaFai Lau , Jakub Kicinski , David Miller Subject: Re: [PATCH 5/5] bpf: Allow to resolve bpf trampoline in unwind In-Reply-To: <8f656ce1-c350-0edd-096b-8f1c395609ec@intel.com> References: <20191229143740.29143-1-jolsa@kernel.org> <20191229143740.29143-6-jolsa@kernel.org> <20200106234639.fo2ctgkb5vumayyl@ast-mbp> <20200107130546.GI290055@krava> <76a10338-391a-ffca-9af8-f407265d146a@intel.com> <20200113094310.GE35080@krava> <9da1c8f9-7ca5-e10b-8931-6871fdbffb23@intel.com> <20200113123728.GA120834@krava> <20200203195826.GB1535545@krava> <8f656ce1-c350-0edd-096b-8f1c395609ec@intel.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Mon, 03 Feb 2020 21:45:17 +0100 Message-ID: <87tv47bdsy.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Bj=C3=B6rn T=C3=B6pel writes: > On 2020-02-03 20:58, Jiri Olsa wrote: > [...] >>>> ...and FWIW, it would be nice with bpf_dispatcher_<...> entries in kal= lsyms >>> >>> ok so it'd be 'bpf_dispatcher_' >>=20 >> hi, >> so the only dispatcher is currently defined as: >> DEFINE_BPF_DISPATCHER(bpf_dispatcher_xdp) >>=20 >> with the bpf_dispatcher_ logic it shows in kallsyms as: >> ffffffffa0450000 t bpf_dispatcher_bpf_dispatcher_xdp [bpf] >> > > Ick! :-P > > >> to fix that, would you guys preffer having: >> DEFINE_BPF_DISPATCHER(xdp) >>=20 >> or using the full dispatcher name as kallsyms name? >> which would require some discipline for future dispatcher names ;-) >> > > I'd prefer the latter, i.e. name "xdp" is shown as bpf_dispatcher_xdp in= =20 > kallsyms. > > ...and if this route is taken, the macros can be changed, so that the=20 > trampoline functions are prefixed with "bpf_dispatcher_". Something like= =20 > this (and also a small '_' cleanup): +1; and thanks for fixing that _ as well - that was really bothering me :) -Toke