From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi Date: Wed, 03 Oct 2018 12:40:48 +0300 Message-ID: <87tvm3id0f.fsf@kamboji.qca.qualcomm.com> References: <20181003073556.28154-1-kai.heng.feng@canonical.com> <20181003073556.28154-3-kai.heng.feng@canonical.com> <87y3bfiees.fsf@kamboji.qca.qualcomm.com> <265BAF93-4BFF-4850-92F7-80AC39496473@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: LKML , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org To: Kai Heng Feng Return-path: In-Reply-To: <265BAF93-4BFF-4850-92F7-80AC39496473@canonical.com> (Kai Heng Feng's message of "Wed, 3 Oct 2018 17:27:41 +0800") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Kai Heng Feng writes: >> On Oct 3, 2018, at 5:10 PM, Kalle Valo wrote: >>=20 >> Kai-Heng Feng writes: >>=20 >>> To avoid the firmware loading race between Bluetooth and WiFi on Intel >>> 8260, load firmware exclusively when BT_INTEL is enabled. >>>=20 >>> Signed-off-by: Kai-Heng Feng >>=20 >> Still the commit log tells nothing about the actual problem which makes >> review impossible. > > Sorry for that. The first two patches [1] only sends to linux-bluetooth a= nd LMKL. For a patchset like this you should CC linux-wireless for all patches, otherwise people just get confused. And even more so as patch 3 seems to depend on the other patches. > I don=E2=80=99t know what really happened at hardware/firmware level, but > making btusb and iwlwifi load firmware sequentially can workaround the > issue. We don't apply ugly workarounds without understanding the issue. > Matt Chen may be able to explain this issue with more detail. Then you need to work with Matt so that the issue is properly explained in the commit log. --=20 Kalle Valo