From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: "Michael Chan" <mchan@broadcom.com>
Cc: nsujir@broadcom.com, davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: tg3: regression of netdev stats
Date: Sat, 02 Mar 2013 15:20:11 +0900 [thread overview]
Message-ID: <87txouwcf8.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <87y5e6wcv1.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Sat, 02 Mar 2013 15:10:42 +0900")
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> "Michael Chan" <mchan@broadcom.com> writes:
>
>> On Fri, 2013-03-01 at 22:21 +0900, OGAWA Hirofumi wrote:
>>> Hi,
>>>
>>> f4a46d1f46a8fece34edd2023e054072b02e110d (tg3: Prevent spurious tx
>>> timeout by setting carrier off before tx disable.) seems to add the bug.
>>>
>>> On 3.8.1 (I didn't use 3.7.x series), "ifconfig" commands doesn't show
>>> any stats, i.e. all stats are zero.
>>
>> No stats on an active device transmitting and receiving packets? I
>> don't seem to see the same problem, but we'll look into this further.
>> Thanks.
>
> Yes, /proc/net/dev didn't show any packet traffic stats (always
> zero). But, e.g. ping/nfs itself works fine.
>
> BTW, chip is
>
> 02:00.0 Ethernet controller [0200]: Broadcom Corporation NetLink BCM57788 Gigabit Ethernet PCIe [14e4:1691] (rev 01)
>
> tg3 0000:02:00.0 eth0: Tigon3 [partno(BCM57788) rev 57780001] (PCI Express) MAC address d4:be:d9:a6:a3:3b
> tg3 0000:02:00.0 eth0: attached PHY driver [Broadcom BCM57780] (mii_bus:phy_addr=200:01)
With some read, this chip seems to be using PHYLIB, and PHYLIB modify
carrier state, so ->link_up confuses with it?
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2013-03-02 6:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 13:21 tg3: regression of netdev stats OGAWA Hirofumi
2013-03-01 15:47 ` Michael Chan
2013-03-02 2:30 ` Nithin Nayak Sujir
2013-03-02 6:10 ` OGAWA Hirofumi
2013-03-02 6:20 ` OGAWA Hirofumi [this message]
2013-03-02 18:56 ` Nithin Nayak Sujir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txouwcf8.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).