From mboxrd@z Thu Jan 1 00:00:00 1970 From: ebiederm@xmission.com (Eric W. Biederman) Subject: Re: netlink scm creds uid and gids are always 0. Date: Fri, 24 Aug 2012 01:19:32 -0700 Message-ID: <87txvsk8h7.fsf@xmission.com> References: <871uiwlrf3.fsf@xmission.com> <1345795065.5904.2287.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain Cc: netdev@vger.kernel.org To: Eric Dumazet Return-path: Received: from out02.mta.xmission.com ([166.70.13.232]:48536 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756196Ab2HXITn (ORCPT ); Fri, 24 Aug 2012 04:19:43 -0400 In-Reply-To: <1345795065.5904.2287.camel@edumazet-glaptop> (Eric Dumazet's message of "Fri, 24 Aug 2012 09:57:45 +0200") Sender: netdev-owner@vger.kernel.org List-ID: Eric Dumazet writes: > On Thu, 2012-08-23 at 23:45 -0700, Eric W. Biederman wrote: >> While working on the kuid_t and kgid_t conversion of the audit subsystem >> I noticed that since the performance problem of scm creds and af_unix >> sockets were fixed af_netlink sockets have not filled in the uid or gid >> of the originator of the socket. >> >> I think all we need is an appropriate cred_to_ucred call to fix this >> regression, but I am going so many different directions right now I >> can't get myself to focus on this long enough to work up an appripriate >> patch to fix. >> >> Eric do you think you might take a gander? > > Wasnt it fixed by e0e3cea46d31d23dc40df0a49a7a2c04fe8edfea > > af_netlink: force credentials passing [CVE-2012-3520] > > Or is it a different thing ? Same thing. I didn't see that fix go by. One more little thing I can cross off my list. Hooray! Eric