From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5851447DD7F for ; Wed, 3 Jun 2026 12:47:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780490838; cv=none; b=qiHhgrEw2++CQ2yvr3a5DXDczTCuGiYe9bcL5VOPZMEqzkX7KL/pcez9S1/0bYY3xgXTr23uQzLWZY3rHAJl62krD+gYYLQkGkkEEW6/udoWbvBUoGbeXgfp/U2OLrdC0W98ugHc5RWhkR0msnhfOnNwY5TXIlxsyrlEVJ2OeT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780490838; c=relaxed/simple; bh=UqiTc5uJeCStJmC9RpnHPzx217mtLCKEuO3YakKuRZo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=JO28gav9w4iQJRP50PaHTA7w5XejRNDZ+awipRq2uOtoh9iptvB1D5WOWwSitq4YyLsZLFvakIMp3yYGBZcFF7Y35/6fr1pNdCRph3jEg2ao+VsfOQ7t5pYoAMlYF3DP5DCMk5txXSNEQ6c3vvfl0B+6C6r2ecR52qSxQUC/zu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=G18ErR6B; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="G18ErR6B" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-bec3f69d343so528166266b.0 for ; Wed, 03 Jun 2026 05:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1780490833; x=1781095633; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=C8IHtiFTYRJaSwK/lgA40BX6+K7NCg68jEs/RoM3v8w=; b=G18ErR6BEly0K+5NGJfw9qWzr+KWN6yubENy+7Mt+bNF1Wc+DuGuwO1iL4l18AMwie 6AVRrUM+tXw8Gj+0wattnN32jlCeOcO6QM0GlbEyEgV09DHGBLqmVew6EL0HGybHipFq ZRH0rDV0WhLv/rx8KcnWnaNlohdiXG9DqTtwjlHtCjTQ4H05ouGYhNe2qdDmXXO5vBEo k3v5e2LwlgiGP9p+4XqzAp8KDtmctUfned7hn2/7xDBqctMwguo5bNTb7SHuawnmnbnF x8pF4uGVrg/1y4fAx3UOzKxpf6rOhWytgGpUCWac+6fiYL4a591DjpTZe/bJUZ4UtRfn ewpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780490833; x=1781095633; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C8IHtiFTYRJaSwK/lgA40BX6+K7NCg68jEs/RoM3v8w=; b=PgrN0q07KTwbrR1eMvIMYHsFLWii26twBxb7h2aa0BxAlQpHg1db/Dpk0fiH7OSjVP DwTCA5W4PPK6o1ddq4O7vywIDirheOTMJHnJx5yUsT/BJy3iqCVUsAq9WhpoLXzzqFAy CYbCjLDnuD6MTaWM4dN5LHMOqyRSYU9tzw2fQngA3h4xwsyUFApDPxeIP61qS6KTeUxH Ww+TJryvvAU1pGnDnGtqxG/tpIGzLAIBp7/EvyRYqPc8BoQat2CB6r/pSrjh2kuoQhoc W1mQXev3xPLyhni1lsrJjlUSqEr9ZoFtAMBQNSaZRxfdt5S8yMS4ycRpL/MIc2S8yBip 9EYw== X-Forwarded-Encrypted: i=1; AFNElJ/UIckIfT+eoHc35GlJxSKttYDWUMt+VF3dwIOVIjoDd7koCNrwLc9wX3P7agGhy0h/3BdKNF8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9tolpFCwQ48WCkISQbEFpwT/Y3OeiCbyLksYiDsid0VydshGL BzzFlEZcQ26NIHMIU4pqIUUXHkUOX78jQ3vduHzLPPr3hw7QFzwR0LrtjYi4Nsj5wjo= X-Gm-Gg: Acq92OHARxlI1u1402pJPZoIswbX/oyxR1Nb2nPQEKO47AIn8MDOy/pWIIRMAcC5b3U zVjYueqBOBxlO1tatAetqXnO23+d7k3xvMEOpeejq00gBX5Nl+vqA0oOI/wqsugV7ig9PffcMCj gm9AaIVG1wY4rPzOZUOHMAczITxrkk6quOyvt8BTmjkcBROIB0YwgldSxkNBR177pgu3zFqjAH3 oS+eWiulHNcZvoKHz6DcJGTBA9iS++8kVxK9S9neISFnBeTJzrlFs7G5OiQcCDkpSJxVa6xIQMr YJ6W5fsAA73jmyqVrBFFnAe19XRXmwNspAe1RbG9LlPtbfDDMZun/AcER79cFyltB020PJ67CnO leH+clkM7sDGyShFVQt8bHQKCsocUAuH4wduLBAY09wKBlECvdhW8rOQ1MwqiFok26cFgEBUyns 0W3xQLYWcnFqHn0fiNGqfQ8YrWpRCIAFtma1PHNvEwInjAeVE= X-Received: by 2002:a17:907:d8b:b0:beb:3dd8:f896 with SMTP id a640c23a62f3a-bf0ae9fc852mr160451566b.34.1780490833586; Wed, 03 Jun 2026 05:47:13 -0700 (PDT) Received: from cloudflare.com ([104.28.21.182]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf051770c7csm151899166b.12.2026.06.03.05.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 05:47:13 -0700 (PDT) From: Jakub Sitnicki To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, maxime.chevallier@bootlin.com, nb@tipi-net.de, lee@kernel.org, linux-leds@vger.kernel.org, pavel@kernel.org, jv@jvosburgh.net, michael.chan@broadcom.com, jhs@mojatatu.com, vinicius.gomes@intel.com, idosch@nvidia.com, razor@blackwall.org, hare@suse.de, jhasan@marvell.com, danieller@nvidia.com Subject: Re: [PATCH net-next v2 03/11] net: document NETDEV_CHANGENAME as ops locked In-Reply-To: <20260603012840.2254293-4-kuba@kernel.org> (Jakub Kicinski's message of "Tue, 2 Jun 2026 18:28:32 -0700") References: <20260603012840.2254293-1-kuba@kernel.org> <20260603012840.2254293-4-kuba@kernel.org> Date: Wed, 03 Jun 2026 14:47:12 +0200 Message-ID: <87v7bz4wq7.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Jun 02, 2026 at 06:28 PM -07, Jakub Kicinski wrote: > NETDEV_CHANGENAME is only emitted from netif_change_name(). > netif_change_name() has two callers both of which hold netdev_lock_ops() > around the call site: > - dev_change_name() > - do_setlink() > > Document NETDEV_CHANGENAME as always ops locked. > > Signed-off-by: Jakub Kicinski > --- Reviewed-by: Jakub Sitnicki