From: Petr Machata <petrm@nvidia.com>
To: Kevin Krakauer <krakauer@google.com>
Cc: <netdev@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] selftests/net: deflake GRO tests and fix return value and output
Date: Tue, 25 Feb 2025 14:16:09 +0100 [thread overview]
Message-ID: <87v7sygo4a.fsf@nvidia.com> (raw)
In-Reply-To: <20250218164555.1955400-1-krakauer@google.com>
Kevin Krakauer <krakauer@google.com> writes:
> diff --git a/tools/testing/selftests/net/gro.sh b/tools/testing/selftests/net/gro.sh
> index 02c21ff4ca81..703173f8c8a9 100755
> --- a/tools/testing/selftests/net/gro.sh
> +++ b/tools/testing/selftests/net/gro.sh
> @@ -21,7 +21,7 @@ run_test() {
> # Each test is run 3 times to deflake, because given the receive timing,
- # Each test is run 3 times to deflake, because given the receive timing,
+ # Each test is run 6 times to deflake, because given the receive timing,
> # not all packets that should coalesce will be considered in the same flow
> # on every try.
> - for tries in {1..3}; do
> + for tries in {1..6}; do
> # Actual test starts here
> ip netns exec $server_ns ./gro "${ARGS[@]}" "--rx" "--iface" "server" \
> 1>>log.txt &
prev parent reply other threads:[~2025-02-25 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 16:45 [PATCH] selftests/net: deflake GRO tests and fix return value and output Kevin Krakauer
2025-02-21 1:04 ` Jakub Kicinski
2025-02-23 15:19 ` Kevin Krakauer
2025-02-24 20:48 ` Jakub Kicinski
2025-02-25 20:05 ` Kevin Krakauer
2025-02-25 13:16 ` Petr Machata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7sygo4a.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=krakauer@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).