netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [BUG] Regression with commit: ptp: Add .getmaxphase callback to ptp_clock_info
@ 2024-09-09 15:13 Christophe ROULLIER
  2024-09-09 15:35 ` Richard Cochran
  0 siblings, 1 reply; 7+ messages in thread
From: Christophe ROULLIER @ 2024-09-09 15:13 UTC (permalink / raw)
  To: Rahul Rameshbabu
  Cc: netdev, David S. Miller, Jakub Kicinski, Shuah Khan,
	Richard Cochran, Maciek Machnikowski

Hi Rahul, All,

I'm facing regression using ptp in STM32 platform with kernel v6.6.

When I use ptp4l I have now an error message :

ptp4l[116.627]: config item (null).step_window is 0
PTP_CLOCK_GETCAPS: Inappropriate ioctl for device
ptp4l[116.627]: clock is not adjustable
failed to create a clock

This regression was introduced in kernel v6.3 by commit "ptp: Add 
.getmaxphase callback to ptp_clock_info" SHA1: 
c3b60ab7a4dff6e6e608e685b70ddc3d6b2aca81:

     Author: Rahul Rameshbabu rrameshbabu@nvidia.com  2023-06-12 23:14:56
     Committer: David S. Miller davem@davemloft.net  2023-06-20 10:02:33
     Parent: 3a9a9a6139286584d1199f555fa4f96f592a3217 (testptp: Add 
support for testing ptp_clock_info .adjphase callback)
     Child:  67ac72a599d833ff7d9b210186a66d46c13f0a18 (net/mlx5: Add 
.getmaxphase ptp_clock_info callback)
     Follows: v6.1-rc1
     Precedes: v6.6-rc7

     ptp: Add .getmaxphase callback to ptp_clock_info

     Enables advertisement of the maximum offset supported by the phase 
control
     functionality of PHCs. The callback is used to return an error if 
an offset
     not supported by the PHC is used in ADJ_OFFSET. The ioctls
     PTP_CLOCK_GETCAPS and PTP_CLOCK_GETCAPS2 now advertise the maximum 
offset a
     PHC's phase control functionality is capable of supporting. 
Introduce new
     sysfs node, max_phase_adjustment.

     Cc: Jakub Kicinski kuba@kernel.org
     Cc: Shuah Khan shuah@kernel.org
     Cc: Richard Cochran richardcochran@gmail.com
     Cc: Maciek Machnikowski maciek@machnikowski.net
     Signed-off-by: Rahul Rameshbabu rrameshbabu@nvidia.com
     Acked-by: Richard Cochran richardcochran@gmail.com
     Signed-off-by: David S. Miller davem@davemloft.net

Is it normal behavior ? If yes could you please tell me what we need to 
change/update in stmmac driver to be compliant with your modifications ?

Thanks for your help/feedback.

Regards,
Christophe.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2024-09-20  4:05 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-09 15:13 [BUG] Regression with commit: ptp: Add .getmaxphase callback to ptp_clock_info Christophe ROULLIER
2024-09-09 15:35 ` Richard Cochran
2024-09-10  6:49   ` Christophe ROULLIER
2024-09-11  4:14     ` Richard Cochran
2024-09-12 14:51       ` Christophe ROULLIER
2024-09-13  3:55         ` Richard Cochran
2024-09-20  4:05           ` Rahul Rameshbabu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).