From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 291701AAE28 for ; Wed, 14 Aug 2024 10:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630786; cv=none; b=GduTVarTVn05saHUhLgyorsC5zW4BPRk5KOWoRZkEOtX+avH20W3e5TAL8xc7fmJM8GSrdgXEjxH713gleyWpI8wO7xDRVM7/ecoFtnfhs5IBcsKcwHWAFc1gORYehWZBsF+Dz4zvkP+AabfPZc8DwpJnZPLCuwd4IjpE+gvDE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630786; c=relaxed/simple; bh=FZz7rN1iHlj31dNr3oGwlQhhvu2v+gYIwV29BtDPZZs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=DW4PAD6+FjnpAKNRlTjabyRTRmXsbZ2URTDAjw3zY+N8GjHE4ow8iLE3hD/DGMJ6OPOTgudlusbXQ8pVjzUTELQdfjr9BuaTTjJXfNxzSyN/qtUrGesWgQi0PIiV+fohWk3Z0JppEVUj9CbnKJ8IX5uI5iB43pmBH7WkKj14H2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cD6jR9ZJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cD6jR9ZJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723630784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ujjRrY9jmmA5hNr8cZIFcVaa3uq5D7CrEXBCcjjRwbY=; b=cD6jR9ZJTju5AGr8dlYOIGO8A3TytJOAhgTxBxkc6NGoeduhzoytp5bZwJmpIGeL/sOY2L OA1irGSmK6mYr84jO3i0DLtVXezQ30JIW3GOTiVY19Q8dXpzcdypPeaNg0a8NNPUHXa2L2 xcGtHXR/hZWwEM581jZ/mnJIJNJehL4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-FubyJwhGOgGK6Nbz07LdDA-1; Wed, 14 Aug 2024 06:19:42 -0400 X-MC-Unique: FubyJwhGOgGK6Nbz07LdDA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4280645e3e0so46668005e9.1 for ; Wed, 14 Aug 2024 03:19:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723630782; x=1724235582; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ujjRrY9jmmA5hNr8cZIFcVaa3uq5D7CrEXBCcjjRwbY=; b=esTMajgDZF76KYKX6rJRTLmy+nKJx9Xc7DHF61RjD8hS6w7Ffz4SiHGsFnw3yT8Etv v/UcJdAIUwzPiTobMTEyNL1m2WF2AR65EKLXAF+IBI8L4vjWaC//qsYZmX0l5TlLDTcy HcLcdR05L2mDHnjh7dcFYlLsNdPQNUysK1JsHeVntbE3IndLXAxNaif3EUs7EGduyWPY Sah7iPHcWnDPEl58eYO8SIgRsa1CqnGw4WB+wOOfBsXIyKR2jzZ8b6sxvElNWkluelcR PNCbIfu7umDtSxgYnC6j35jhMVF8UMaWjVaZKC7Y0MXrmwMpp7/jcl6PkZpG6mm4kJa3 bsBA== X-Forwarded-Encrypted: i=1; AJvYcCXPPTm4X85dSLLsWjsQdI+ssA3yofqiJP6GFiIV1LOsC88HV6KmMksFYIhyX2C7SOB2jEWLE8O2wz0msA0XAjBMM6iJA9Xm X-Gm-Message-State: AOJu0YxtJsHRpbo8oTVQDFnAqueBXjq8OkoCoE8JE4u7zUVWzUnPCmER 35ekSt5PZQnODaN3GeG+RWV0gQh2WT/pwqQNcuHvasKf6wcUmB0AKteB2OXVLh4E6q0ss2yiagC VTSVQ+YvWE8G7IonkoTYE7IiX8RG1DiYLFLe5F22v91Dr1PhU5L6+Xw== X-Received: by 2002:adf:e644:0:b0:368:6b28:5911 with SMTP id ffacd0b85a97d-37177760a1bmr1546852f8f.2.1723630781709; Wed, 14 Aug 2024 03:19:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFC502yJUKbD+xbFsQIpm66zQN+FX64YOh1xGOvttuPua4rFxKJdQmq1Q8KvP6ui+G9bsDLMg== X-Received: by 2002:adf:e644:0:b0:368:6b28:5911 with SMTP id ffacd0b85a97d-37177760a1bmr1546827f8f.2.1723630781208; Wed, 14 Aug 2024 03:19:41 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4c938280sm12483923f8f.36.2024.08.14.03.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 03:19:40 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id D04C714ADF7D; Wed, 14 Aug 2024 12:19:39 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Hangbin Liu , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Ignat Korchagin , linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, Hangbin Liu , Yi Chen Subject: Re: [PATCH net 2/2] selftests: udpgro: no need to load xdp for gro In-Reply-To: <20240814075758.163065-3-liuhangbin@gmail.com> References: <20240814075758.163065-1-liuhangbin@gmail.com> <20240814075758.163065-3-liuhangbin@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 14 Aug 2024 12:19:39 +0200 Message-ID: <87v803csp0.fsf@toke.dk> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hangbin Liu writes: > After commit d7db7775ea2e ("net: veth: do not manipulate GRO when using > XDP"), there is no need to load XDP program to enable GRO. On the other > hand, the current test is failed due to loading the XDP program. e.g. > > # selftests: net: udpgro.sh > # ipv4 > # no GRO ok > # no GRO chk cmsg ok > # GRO ./udpgso_bench_rx: recv: bad = packet len, got 1472, expected 14720 > # > # failed > > [...] > > # bad GRO lookup ok > # multiple GRO socks ./udpgso_bench_rx: recv: bad = packet len, got 1452, expected 14520 > # > # ./udpgso_bench_rx: recv: bad packet len, got 1452, expected 14520 > # > # failed > ok 1 selftests: net: udpgro.sh > > After fix, all the test passed. > > # ./udpgro.sh > ipv4 > no GRO ok > [...] > multiple GRO socks ok > > Fixes: d7db7775ea2e ("net: veth: do not manipulate GRO when using XDP") > Reported-by: Yi Chen > Closes: https://issues.redhat.com/browse/RHEL-53858 > Signed-off-by: Hangbin Liu Reviewed-by: Toke H=C3=B8iland-J=C3=B8rgensen