From: "Toke Høiland-Jørgensen" <toke@kernel.org>
To: Duan Jiong <djduanjiong@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH v3] veth: Drop MTU check when forwarding packets
Date: Thu, 08 Aug 2024 11:23:22 +0200 [thread overview]
Message-ID: <87v80bpdv9.fsf@toke.dk> (raw)
In-Reply-To: <20240808070428.13643-1-djduanjiong@gmail.com>
Duan Jiong <djduanjiong@gmail.com> writes:
> When the mtu of the veth card is not the same at both ends, there
> is no need to check the mtu when forwarding packets, and it should
> be a permissible behavior to allow receiving packets with larger
> mtu than your own.
Erm, huh? The MTU check is against the receiving interface, so AFAICT
your patch just disables MTU checking entirely for veth devices, which
seems ill-advised.
What's the issue you are trying to fix, exactly?
-Toke
next prev parent reply other threads:[~2024-08-08 9:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 7:04 [PATCH v3] veth: Drop MTU check when forwarding packets Duan Jiong
2024-08-08 9:23 ` Toke Høiland-Jørgensen [this message]
2024-08-08 9:55 ` Duan Jiong
2024-08-08 10:21 ` Toke Høiland-Jørgensen
[not found] ` <00f872ac-4f59-4857-9c50-2d87ed860d4f@Spark>
2024-08-08 12:24 ` Toke Høiland-Jørgensen
2024-08-08 19:38 ` Willem de Bruijn
2024-08-09 9:47 ` Toke Høiland-Jørgensen
2024-08-12 9:11 ` Duan Jiong
2024-08-13 11:40 ` Toke Høiland-Jørgensen
2024-08-14 6:42 ` Duan Jiong
2024-08-16 21:09 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v80bpdv9.fsf@toke.dk \
--to=toke@kernel.org \
--cc=djduanjiong@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).