From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HQlnKKQi" Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8679595; Mon, 11 Dec 2023 10:08:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702318119; x=1733854119; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=zsHw8c+yNsgNCrRgEh9GvMAaMJXHxP/gdyNdElE3dk0=; b=HQlnKKQiDoZ3kwztSPtqoh1ltPlKiqIBzO9SxKKDOFpYKye8GAJqAlD/ RtjEEhGVylp02QZuArCpPGYvMiMEWl3p5m0AjlmsD9+zwjtKkRb17iuPy fUrvHFxmiPkihDEyq0fewHilmfaTq8X06f8TQKXryhB0oLN8U8zEhH3Mc oIrAnJNiXWPL7YKvB8dgwmPM66FIF3HeHzC4SFt1oIeXCrSCY7OYRAkGY xtFd5mQqUoDVzaODK5jsBeqNSLq7or0eiCh5fgQEmUdEYASFDG2YHG1s0 GVzCSkssnwhs+j5OW8QNsZB/WXTuz3OlkWkJ3T4i3kXqV1Xxd2kA9WL4v Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10921"; a="425810997" X-IronPort-AV: E=Sophos;i="6.04,268,1695711600"; d="scan'208";a="425810997" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 10:08:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,268,1695711600"; d="scan'208";a="17595834" Received: from ashnaupa-mobl1.amr.corp.intel.com (HELO vcostago-mobl3) ([10.209.96.90]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 10:08:37 -0800 From: Vinicius Costa Gomes To: Rodrigo CADORE CATALDO , Rodrigo Cataldo via B4 Relay , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Aravindhan Gunasekaran , Mallikarjuna Chilakala Cc: "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Kurt Kanzenbach Subject: RE: [PATCH iwl-net] igc: Fix hicredit calculation In-Reply-To: References: <20231208-igc-fix-hicredit-calc-v1-1-7e505fbe249d@l-acoustics.com> <871qbwry9y.fsf@intel.com> Date: Mon, 11 Dec 2023 10:08:37 -0800 Message-ID: <87v894r4re.fsf@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Rodrigo CADORE CATALDO writes: >> -----Original Message----- >> From: Vinicius Costa Gomes >> >> Rodrigo Cataldo via B4 Relay >> writes: >> >> > From: Rodrigo Cataldo >> > >> > According to the Intel Software Manual for I225, Section 7.5.2.7, >> > hicredit should be multiplied by the constant link-rate value, 0x7736. >> > >> > Currently, the old constant link-rate value, 0x7735, from the boards >> > supported on igb are being used, most likely due to a copy'n'paste, as >> > the rest of the logic is the same for both drivers. >> > >> > Update hicredit accordingly. >> > >> > Fixes: 1ab011b0bf07 ("igc: Add support for CBS offloading") >> > Reviewed-by: Kurt Kanzenbach >> > Signed-off-by: Rodrigo Cataldo >> > --- >> >> Very good catch. >> >> Acked-by: Vinicius Costa Gomes >> >> Just for curiosity, my test machines are busy right now, what kind of >> difference are you seeing? >> > > Hello Vinicius, thank you for the ACK. > > For our internal setup, this does not make a difference. My understanding is > that hicredit is used for non-SR traffic mixed with SR traffic (i.e., hicredit is > directly related to the max non-SR frame size). But our setup does not mix > them (q0 is used only for milan audio/clock SR class A). I see. > > Let me know if you think we need a testcase for this. > It was just curiority. No need. Thanks. >> > This is a simple fix for the credit calculation on igc devices >> > (i225/i226) to match the Intel software manual. >> > >> > This is my first contribution to the Linux Kernel. Apologies for any >> > mistakes and let me know if I improve anything. >> > --- >> > drivers/net/ethernet/intel/igc/igc_tsn.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c >> b/drivers/net/ethernet/intel/igc/igc_tsn.c >> > index a9c08321aca9..22cefb1eeedf 100644 >> > --- a/drivers/net/ethernet/intel/igc/igc_tsn.c >> > +++ b/drivers/net/ethernet/intel/igc/igc_tsn.c >> > @@ -227,7 +227,7 @@ static int igc_tsn_enable_offload(struct igc_adapter >> *adapter) >> > wr32(IGC_TQAVCC(i), tqavcc); >> > >> > wr32(IGC_TQAVHC(i), >> > - 0x80000000 + ring->hicredit * 0x7735); >> > + 0x80000000 + ring->hicredit * 0x7736); >> > } else { >> > /* Disable any CBS for the queue */ >> > txqctl &= ~(IGC_TXQCTL_QAV_SEL_MASK); >> > >> > --- >> > base-commit: 2078a341f5f609d55667c2dc6337f90d8f322b8f >> > change-id: 20231206-igc-fix-hicredit-calc-028bf73c50a8 >> > >> > Best regards, >> > -- >> > Rodrigo Cataldo >> > >> >> Cheers, >> -- >> Vinicius > > Best Regards, > Rodrigo Cataldo Cheers, -- Vinicius