* [PATCH] wireless: airo: remove ISA_DMA_API dependency
@ 2023-04-17 20:51 Arnd Bergmann
2023-04-19 13:34 ` Simon Horman
2023-04-20 12:38 ` wifi: " Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-04-17 20:51 UTC (permalink / raw)
To: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: Arnd Bergmann, linux-wireless, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
This driver does not actually use the ISA DMA API, it is purely
PIO based, so remove the dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/wireless/cisco/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/cisco/Kconfig b/drivers/net/wireless/cisco/Kconfig
index 681bfc2d740a..b40ee25aca99 100644
--- a/drivers/net/wireless/cisco/Kconfig
+++ b/drivers/net/wireless/cisco/Kconfig
@@ -14,7 +14,7 @@ if WLAN_VENDOR_CISCO
config AIRO
tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
- depends on CFG80211 && ISA_DMA_API && (PCI || BROKEN)
+ depends on CFG80211 && (PCI || BROKEN)
select WIRELESS_EXT
select CRYPTO
select CRYPTO_SKCIPHER
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] wireless: airo: remove ISA_DMA_API dependency
2023-04-17 20:51 [PATCH] wireless: airo: remove ISA_DMA_API dependency Arnd Bergmann
@ 2023-04-19 13:34 ` Simon Horman
2023-04-19 14:17 ` Kalle Valo
2023-04-20 12:38 ` wifi: " Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Simon Horman @ 2023-04-19 13:34 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Arnd Bergmann, linux-wireless, netdev, linux-kernel
On Mon, Apr 17, 2023 at 10:51:24PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This driver does not actually use the ISA DMA API, it is purely
> PIO based, so remove the dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd,
I think that the subject prefix should probably be 'wifi: airo: '.
That nit aside, FWIIW, this looks good to me.
Reviewed-by: Simon Horman <simon.horman@corigine.com>
> ---
> drivers/net/wireless/cisco/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/cisco/Kconfig b/drivers/net/wireless/cisco/Kconfig
> index 681bfc2d740a..b40ee25aca99 100644
> --- a/drivers/net/wireless/cisco/Kconfig
> +++ b/drivers/net/wireless/cisco/Kconfig
> @@ -14,7 +14,7 @@ if WLAN_VENDOR_CISCO
>
> config AIRO
> tristate "Cisco/Aironet 34X/35X/4500/4800 ISA and PCI cards"
> - depends on CFG80211 && ISA_DMA_API && (PCI || BROKEN)
> + depends on CFG80211 && (PCI || BROKEN)
> select WIRELESS_EXT
> select CRYPTO
> select CRYPTO_SKCIPHER
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] wireless: airo: remove ISA_DMA_API dependency
2023-04-19 13:34 ` Simon Horman
@ 2023-04-19 14:17 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2023-04-19 14:17 UTC (permalink / raw)
To: Simon Horman
Cc: Arnd Bergmann, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Arnd Bergmann, linux-wireless, netdev, linux-kernel
Simon Horman <simon.horman@corigine.com> writes:
> On Mon, Apr 17, 2023 at 10:51:24PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> This driver does not actually use the ISA DMA API, it is purely
>> PIO based, so remove the dependency.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Hi Arnd,
>
> I think that the subject prefix should probably be 'wifi: airo: '.
> That nit aside, FWIIW, this looks good to me.
I can fix that during commit.
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Thanks for the review!
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: wifi: airo: remove ISA_DMA_API dependency
2023-04-17 20:51 [PATCH] wireless: airo: remove ISA_DMA_API dependency Arnd Bergmann
2023-04-19 13:34 ` Simon Horman
@ 2023-04-20 12:38 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2023-04-20 12:38 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Arnd Bergmann, linux-wireless, netdev, linux-kernel
Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This driver does not actually use the ISA DMA API, it is purely
> PIO based, so remove the dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
Patch applied to wireless-next.git, thanks.
09be55585d27 wifi: airo: remove ISA_DMA_API dependency
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230417205131.1560074-1-arnd@kernel.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-04-20 12:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-17 20:51 [PATCH] wireless: airo: remove ISA_DMA_API dependency Arnd Bergmann
2023-04-19 13:34 ` Simon Horman
2023-04-19 14:17 ` Kalle Valo
2023-04-20 12:38 ` wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).