From: Kalle Valo <kvalo@kernel.org>
To: Ziyang Xuan <william.xuanziyang@huawei.com>
Cc: <srini.raju@purelifi.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] wifi: plfxlc: fix potential memory leak in __lf_x_usb_enable_rx()
Date: Sat, 19 Nov 2022 08:42:16 +0200 [thread overview]
Message-ID: <87v8nbphrr.fsf@kernel.org> (raw)
In-Reply-To: <20221119051900.1192401-1-william.xuanziyang@huawei.com> (Ziyang Xuan's message of "Sat, 19 Nov 2022 13:19:00 +0800")
Ziyang Xuan <william.xuanziyang@huawei.com> writes:
> urbs does not be freed in exception paths in __lf_x_usb_enable_rx().
> That will trigger memory leak. To fix it, add kfree() for urbs within
> "error" label. Compile tested only.
>
> Fixes: 68d57a07bfe5 ("wireless: add plfxlc driver for pureLiFi X, XL, XC devices")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
> ---
> drivers/net/wireless/purelifi/plfxlc/usb.c | 1 +
> 1 file changed, 1 insertion(+)
plfxlc patches go to wireless tree, not net. But I think I'll take this
to wireless-next actually.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-11-19 6:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 5:19 [PATCH net] wifi: plfxlc: fix potential memory leak in __lf_x_usb_enable_rx() Ziyang Xuan
2022-11-19 6:42 ` Kalle Valo [this message]
2022-11-19 9:20 ` Ziyang Xuan (William)
2022-11-28 13:56 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8nbphrr.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=srini.raju@purelifi.com \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).