From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D513C433FE for ; Wed, 9 Mar 2022 21:52:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237860AbiCIVxV (ORCPT ); Wed, 9 Mar 2022 16:53:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230398AbiCIVxU (ORCPT ); Wed, 9 Mar 2022 16:53:20 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 45073FABD6 for ; Wed, 9 Mar 2022 13:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646862740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jt46+1UBm/1UiUEBiRZpbEhGZ+ENlJfo7E1vE1EyEB4=; b=K6h9e7pUCt9aj5A0jK2gKL/GVd7bDgyViMXcmXK8iEyAF2YMO2otl1VEz4bnmle+empkBI kpHxqEYBMh1fXjENJrTZymNNYwncv+hzz5E1XxuxDEctBH4jhBsY+2EYx6HlXLQmXfYypE UOz9vmeUZDmrRwSx16KHePpM+BbWr+E= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-126-M1bSTyInP5CV-N6wP3SNuQ-1; Wed, 09 Mar 2022 16:52:19 -0500 X-MC-Unique: M1bSTyInP5CV-N6wP3SNuQ-1 Received: by mail-ej1-f69.google.com with SMTP id ga31-20020a1709070c1f00b006cec400422fso1982652ejc.22 for ; Wed, 09 Mar 2022 13:52:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=Jt46+1UBm/1UiUEBiRZpbEhGZ+ENlJfo7E1vE1EyEB4=; b=ZB1x3zudYnryfT8xF4g8goo/xvxQ1NHaNp8knQg9MNRcW8c1IKwxgCbjkpbrUE+dHh 7Px8TH8wKe5APsmEoUZNeJ68ryHDbfQeZ21SuCJfaDt/bpyc8boYtBlg2QJnMyd8OTEP yyQWEOv8qoj06LBG4UEFpJM2Ss/HbUMkehiEnBl5KXGSU4UOTOoSBt5M2syaeIyxDWcI 6wEWaEKf7uB0cmeHfSGqfBDXkDQjT7+Kg/cSCDiAH701xCzCd5pBaWGx8BSyatHbItZ6 aHDsk9IsvBYUwBYA7WPWi1z/2owC0rHiOu5zKbrU71bqD9EgVIdNclPXlFtvw91GPcol WOSQ== X-Gm-Message-State: AOAM53368yZsSsLYylVXRBz5gk+PnvnVXb3PuKZ85TllpDWtNjtngF+q 1LkKvWzMS3+U6acoWFIQNRM2OMbr0KRWP+O0jMPeAnJ3HpDlq4KY0a0XvKeD2GtKVLiq3oOOKQ3 pgooO1nSiCt9E4RuD X-Received: by 2002:a05:6402:168e:b0:416:1714:a45c with SMTP id a14-20020a056402168e00b004161714a45cmr1431823edv.313.1646862737111; Wed, 09 Mar 2022 13:52:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkx7BIwgJLX3HbEgIm5+oS2n8RfHGLt73XmG46iPOoMx8OhSB+V6R63JXLAqYDdf2VUefnwA== X-Received: by 2002:a05:6402:168e:b0:416:1714:a45c with SMTP id a14-20020a056402168e00b004161714a45cmr1431731edv.313.1646862735382; Wed, 09 Mar 2022 13:52:15 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id z3-20020a056402274300b004169771bd91sm1226184edd.39.2022.03.09.13.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 13:52:14 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 13C8F192B64; Wed, 9 Mar 2022 22:52:14 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Sebastian Andrzej Siewior , Jakub Kicinski Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , "David S. Miller" , Ingo Molnar , Jesper Dangaard Brouer , John Fastabend , KP Singh , Martin KaFai Lau , Song Liu , Steven Rostedt , Thomas Gleixner , Yonghong Song Subject: Re: [PATCH net v2] xdp: xdp_mem_allocator can be NULL in trace_mem_connect(). In-Reply-To: References: X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 09 Mar 2022 22:52:14 +0100 Message-ID: <87v8wmvlo1.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sebastian Andrzej Siewior writes: > Since the commit mentioned below __xdp_reg_mem_model() can return a NULL > pointer. This pointer is dereferenced in trace_mem_connect() which leads > to segfault. > > The trace points (mem_connect + mem_disconnect) were put in place to > pair connect/disconnect using the IDs. The ID is only assigned if > __xdp_reg_mem_model() does not return NULL. That connect trace point is > of no use if there is no ID. > > Skip that connect trace point if xdp_alloc is NULL. > > [ Toke H=C3=B8iland-J=C3=B8rgensen delivered the reasoning for skipping t= he trace > point ] > > Fixes: 4a48ef70b93b8 ("xdp: Allow registering memory model without rxq re= ference") > Signed-off-by: Sebastian Andrzej Siewior With Steven's fix: Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen