netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tobias Waldekranz <tobias@waldekranz.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, andrew@lunn.ch, vivien.didelot@gmail.com,
	f.fainelli@gmail.com, olteanv@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Add tx fwd offload PVT on intermediate devices
Date: Sat, 11 Dec 2021 22:20:28 +0100	[thread overview]
Message-ID: <87v8zu2603.fsf@waldekranz.com> (raw)
In-Reply-To: <20211210211851.6b8773e1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Fri, Dec 10, 2021 at 21:18, Jakub Kicinski <kuba@kernel.org> wrote:
> On Thu,  9 Dec 2021 23:24:24 +0100 Tobias Waldekranz wrote:
>> In a typical mv88e6xxx switch tree like this:
>> 
>>   CPU
>>    |    .----.
>> .--0--. | .--0--.
>> | sw0 | | | sw1 |
>> '-1-2-' | '-1-2-'
>>     '---'
>> 
>> If sw1p{1,2} are added to a bridge that sw0p1 is not a part of, sw0
>> still needs to add a crosschip PVT entry for the virtual DSA device
>> assigned to represent the bridge.
>> 
>> Fixes: ce5df6894a57 ("net: dsa: mv88e6xxx: map virtual bridges with forwarding offload in the PVT")
>
> Hm, should this go to net? The commit above is in 5.15 it seems.

Since there was no cover letter for this patch I put that motivation
after the commit message cutoff:

    Though this is a bugfix, it still targets net-next as it depends on
    the recent work done by Vladimir here:

    https://lore.kernel.org/netdev/20211206165758.1553882-1-vladimir.oltean@nxp.com/

I have patches for 5.15 but the implementation is completely
different. Given that (1) multichip devices are pretty uncommon to begin
with and (2) that this configuration is also rare, I thought it might be
more trouble than it was worth.

Let me know if you want me to send that too - but independent of that, I
think this should go in on net-next.

  reply	other threads:[~2021-12-11 21:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 22:24 [PATCH net-next] net: dsa: mv88e6xxx: Add tx fwd offload PVT on intermediate devices Tobias Waldekranz
2021-12-09 22:41 ` Vladimir Oltean
2021-12-09 22:52   ` Tobias Waldekranz
2021-12-11  5:18 ` Jakub Kicinski
2021-12-11 21:20   ` Tobias Waldekranz [this message]
2021-12-13 16:08     ` Jakub Kicinski
2021-12-12 16:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8zu2603.fsf@waldekranz.com \
    --to=tobias@waldekranz.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).