From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Joe Perches <joe@perches.com>, Pkshih <pkshih@realtek.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"davem\@davemloft.net" <davem@davemloft.net>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kuba\@kernel.org" <kuba@kernel.org>
Subject: Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses
Date: Thu, 27 Aug 2020 12:27:32 +0300 [thread overview]
Message-ID: <87v9h4bfqz.fsf@codeaurora.org> (raw)
In-Reply-To: <374359f9-8199-f4b9-0596-adc41c8c664f@lwfinger.net> (Larry Finger's message of "Mon, 27 Jul 2020 11:25:21 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 7/27/20 9:52 AM, Joe Perches wrote:
>> On Mon, 2020-07-27 at 09:04 +0000, Pkshih wrote:
>>> So, I think you would like to have parenthesis intentionally.
>>> If so,
>>> test1 ? : (test2 ? :)
>>> would be better.
>>>
>>>
>>> If not,
>>> test1 ? : test2 ? :
>>> may be what you want (without any parenthesis).
>>
>> Use whatever style you like, it's unimportant to me
>> and it's not worth spending any real time on it.
>
> If you are so busy, why did you jump in with patches that you knew I
> was already working on? You knew because you critiqued my first
> submission.
Yeah, I don't understand this either. First stepping on Larry's work and
when after getting review comments claiming being busy and not caring is
contradicting.
> @Kalle: Please drop my contributions in the sequence "PATCH v2 00/15]
> rtlwifi: Change RT_TRACE into rtl_dbg for all drivers".
Is there a technical reason for that? I prefer that patchset more,
nicely split in smaller patches and it's fully available from patchwork.
Patch 15 had a build problem but I can drop that for now, it can be
resent separately:
https://patchwork.kernel.org/patch/11681621/
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-08-27 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 19:55 [PATCH 0/6] rtlwifi: Convert RT_TRACE to rtl_dbg and neatening Joe Perches
2020-07-25 19:55 ` [PATCH 1/6] rtlwifi: Convert RT_TRACE to rtl_dbg Joe Perches
2020-07-25 19:55 ` [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses Joe Perches
2020-07-27 6:07 ` Pkshih
2020-07-27 8:27 ` Joe Perches
2020-07-27 9:04 ` Pkshih
2020-07-27 14:52 ` Joe Perches
2020-07-27 16:25 ` Larry Finger
2020-07-27 16:33 ` Joe Perches
2020-08-27 9:27 ` Kalle Valo [this message]
2020-08-27 10:52 ` Joe Perches
2020-07-25 19:55 ` [PATCH 3/6] rtlwifi: Better spacing around " Joe Perches
2020-07-25 19:55 ` [PATCH 4/6] rtlwifi: Convert rtl_dbg embedded function names to %s: ..., __func__ Joe Perches
2020-07-25 19:55 ` [PATCH 5/6] rtlwifi: Avoid multiline dereferences in rtl_dbg uses Joe Perches
2020-07-25 19:55 ` [PATCH 6/6] rtlwifi: Convert sleeped to slept " Joe Perches
2020-07-25 21:03 ` [PATCH 0/6] rtlwifi: Convert RT_TRACE to rtl_dbg and neatening Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9h4bfqz.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).