From: Esben Haabendal <esben@geanix.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
"Michal Simek" <michal.simek@xilinx.com>,
"Petr Štetiar" <ynezz@true.cz>
Subject: Re: [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce parameters
Date: Tue, 18 Feb 2020 15:28:13 +0100 [thread overview]
Message-ID: <87v9o4gebm.fsf@geanix.com> (raw)
In-Reply-To: <20200218133943.GA10541@lunn.ch> (Andrew Lunn's message of "Tue, 18 Feb 2020 14:39:43 +0100")
Andrew Lunn <andrew@lunn.ch> writes:
> Hi Esben
>
>> + if (ec->tx_coalesce_usecs)
>> + lp->coalesce_delay_tx =
>> + min(255U, (ec->tx_coalesce_usecs * 100) / 512);
>> +
>> + pr_info("%d -> %d %d -> %d\n",
>> + ec->rx_coalesce_usecs, lp->coalesce_delay_rx,
>> + ec->tx_coalesce_usecs, lp->coalesce_delay_tx);
>
> I guess this is left over from debug? You don't actually want it here?
Yes, I will remove that in v2. Thanks.
/Esben
prev parent reply other threads:[~2020-02-18 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 8:27 [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce parameters Esben Haabendal
2020-02-18 13:39 ` Andrew Lunn
2020-02-18 14:28 ` Esben Haabendal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9o4gebm.fsf@geanix.com \
--to=esben@geanix.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).