From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBB55C3403D for ; Tue, 18 Feb 2020 14:28:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A7C8208C4 for ; Tue, 18 Feb 2020 14:28:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=geanix.com header.i=@geanix.com header.b="NyLbT3+Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbgBRO2R (ORCPT ); Tue, 18 Feb 2020 09:28:17 -0500 Received: from first.geanix.com ([116.203.34.67]:50546 "EHLO first.geanix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726422AbgBRO2R (ORCPT ); Tue, 18 Feb 2020 09:28:17 -0500 Received: from localhost (unknown [193.163.1.7]) by first.geanix.com (Postfix) with ESMTPSA id D029AC0029; Tue, 18 Feb 2020 14:27:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=geanix.com; s=first; t=1582036045; bh=mHzt9vtnKLHNpF1/+TJ0Mqr2u8xuO4Fqk8u6fW/EDks=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=NyLbT3+ZSzHRzg/t+SZBSVHIzj+RTsJ8tdYGFRfqqiEUS/jqPTEink6P8B1VeKQhi 03YfkqFq9I2sRDrqM0dSjOclLHHJv3YSXe9r0dW85VE4IFynlrAuMO4csbTBBuHRnf mVm7wqFLiL/jbvxZDh1AZ0iJTuPQgiOV89lvoD2fmQrNuShJ7VB4SWVpAUPNcPjNQn UAk4u1b5PwE9sqkSOVAwe/PgUxu/6Tfe9avRct3mnZ+rsG7n4Jzszl2sNz81cZIIrU UEQzUDO1jdtad3twes8tIoMr/IP5PMAGMuHXN3eRb2MmX8kv23mFFOaLn88y4gVA/1 9eN3uSeayg7ZA== From: Esben Haabendal To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "David S . Miller" , Michal Simek , Petr =?utf-8?Q?=C5=A0tetiar?= Subject: Re: [PATCH 8/8] net: ll_temac: Add ethtool support for coalesce parameters References: <20200218082741.7710-1-esben@geanix.com> <20200218133943.GA10541@lunn.ch> Date: Tue, 18 Feb 2020 15:28:13 +0100 In-Reply-To: <20200218133943.GA10541@lunn.ch> (Andrew Lunn's message of "Tue, 18 Feb 2020 14:39:43 +0100") Message-ID: <87v9o4gebm.fsf@geanix.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Andrew Lunn writes: > Hi Esben > >> + if (ec->tx_coalesce_usecs) >> + lp->coalesce_delay_tx = >> + min(255U, (ec->tx_coalesce_usecs * 100) / 512); >> + >> + pr_info("%d -> %d %d -> %d\n", >> + ec->rx_coalesce_usecs, lp->coalesce_delay_rx, >> + ec->tx_coalesce_usecs, lp->coalesce_delay_tx); > > I guess this is left over from debug? You don't actually want it here? Yes, I will remove that in v2. Thanks. /Esben