netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: "Miguel Rodríguez Pérez" <miguel@det.uvigo.gal>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] cdc_ncm: Hook into usbnet_change_mtu respecting usbnet,driver_info
Date: Sat, 30 Jun 2018 14:01:22 +0200	[thread overview]
Message-ID: <87vaa0zdnx.fsf@miraculix.mork.no> (raw)
In-Reply-To: <f7e03920-e32d-e49c-9c9e-d7a4473828ee@det.uvigo.gal> ("Miguel Rodríguez Pérez"'s message of "Sat, 30 Jun 2018 13:26:48 +0200")

Miguel Rodríguez Pérez <miguel@det.uvigo.gal> writes:

> Change the way cdc_ncm_change_mtu hooks into the netdev_ops
> structure so that changes into usbnet driver_info operations
> can be respected. Without this, is was not possible to hook
> into usbnet_set_rx_mode.

Please export usbnet_set_rx_mode instead, so that cdc_ncm_netdev_ops
can be kept const.


Bjørn

  reply	other threads:[~2018-06-30 12:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-30 11:21 [PATCH 0/2 ] cdc_ncm: Handle multicast Ethernet traffic Miguel Rodríguez Pérez
2018-06-30 11:26 ` [PATCH 1/2] cdc_ncm: Hook into usbnet_change_mtu respecting usbnet,driver_info Miguel Rodríguez Pérez
2018-06-30 12:01   ` Bjørn Mork [this message]
2018-06-30 14:22     ` Miguel Rodríguez Pérez
2018-06-30 11:26 ` [PATCH 2/2] cdc_ncm: Admit multicast traffic Miguel Rodríguez Pérez
2018-06-30 12:17   ` Bjørn Mork
2018-06-30 14:22     ` Miguel Rodríguez Pérez
2018-06-30 12:22 ` [PATCH 0/2 ] cdc_ncm: Handle multicast Ethernet traffic Bjørn Mork
2018-06-30 13:43   ` Miguel Rodríguez Pérez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vaa0zdnx.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=linux-usb@vger.kernel.org \
    --cc=miguel@det.uvigo.gal \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).