RE: [PATCH] r8152: Add support for setting MAC to system's Auxiliary MAC address

Mario_Limonciello
2016-06-02T14:29:41Z

> -----Original Message-----
> From: Bjørn Mork [mailto:bjorn@mork.no]
> Sent: Thursday, June 2, 2016 3:11 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: gregkh@linuxfoundation.org; hayeswang@realtek.com; linux-
> kernel@vger.kernel.org; netdev@vger.kernel.org; linux-
> usb@vger.kernel.org; pali.rohar@gmail.com; anthony.wong@canonical.com
> Subject: Re: [PATCH] r8152: Add support for setting MAC to system's
> Auxiliary MAC address
>
> <Mario_Limonciello@Dell.com> writes:
>
> >> > +static u8 amac_ascii_to_hex(int c) {
> >> > + if (c <= 0x39)
> >> > + return (u8)(c - 0x30);
> >> > + else if (c <= 0x46)
> >> > + return (u8)(c - 0x37);
> >> > + return (u8)(c - 0x57);
> >> > +}
> >>
> >
> > Sorry forgot to address this.
> >
> >> We really don't have such a function somewhere in the kernel already?
> >
> > There is a function in acpi/acpica/uthex.c that does this, but it
> > doesn't seem to be used by anything outside of acpica so far. Would it be
> OK style wise to #include " ../../acpi/acpica/acutils.h" from r8152.c?
>
> Makes me wonder where you looked.... You have hex_to_bin() and
> hex2bin() in include/linux/kernel.h
>

Thank you, I completely missed that. I wasn't looking for literals in my grepping. I'll use this instead.

> You could look at usbnet_get_ethernet_addr() for an example of how to do
> this properly. It's pretty close to this driver in the tree, and should be a
> natural starting point before reinventing the wheel...
>

OK will do.