From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Alexander Lobakin <aleksander.lobakin@intel.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
Stanislav Fomichev <sdf@fomichev.me>,
Magnus Karlsson <magnus.karlsson@intel.com>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 01/10] xsk: align &xdp_buff_xsk harder
Date: Wed, 04 Dec 2024 11:27:01 +0100 [thread overview]
Message-ID: <87wmgfaglm.fsf@toke.dk> (raw)
In-Reply-To: <20241203173733.3181246-2-aleksander.lobakin@intel.com>
Alexander Lobakin <aleksander.lobakin@intel.com> writes:
> After the series "XSk buff on a diet" by Maciej, the greatest pow-2
> which &xdp_buff_xsk can be divided got reduced from 16 to 8 on x86_64.
> Also, sizeof(xdp_buff_xsk) now is 120 bytes, which, taking the previous
> sentence into account, leads to that it leaves 8 bytes at the end of
> cacheline, which means an array of buffs will have its elements
> messed between the cachelines chaotically.
> Use __aligned_largest for this struct. This alignment is usually 16
> bytes, which makes it fill two full cachelines and align an array
> nicely. ___cacheline_aligned may be excessive here, especially on
> arches with 128-256 byte CLs, as well as 32-bit arches (76 -> 96
> bytes on MIPS32R2), while not doing better than _largest.
>
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Ohh, didn't know about that attribute - neat!
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2024-12-04 10:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 17:37 [PATCH net-next v6 00/10] xdp: a fistful of generic changes pt. I Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 01/10] xsk: align &xdp_buff_xsk harder Alexander Lobakin
2024-12-04 10:27 ` Toke Høiland-Jørgensen [this message]
2024-12-03 17:37 ` [PATCH net-next v6 02/10] bpf, xdp: constify some bpf_prog * function arguments Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 03/10] xdp, xsk: constify read-only arguments of some static inline helpers Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 04/10] xdp: allow attaching already registered memory model to xdp_rxq_info Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 05/10] xsk: allow attaching XSk pool via xdp_rxq_info_reg_mem_model() Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 06/10] xdp: register system page pool as an XDP memory model Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 07/10] netmem: add a couple of page helper wrappers Alexander Lobakin
2024-12-04 10:49 ` Toke Høiland-Jørgensen
2024-12-06 4:03 ` Mina Almasry
2024-12-03 17:37 ` [PATCH net-next v6 08/10] page_pool: make page_pool_put_page_bulk() handle array of netmems Alexander Lobakin
2024-12-04 10:50 ` Toke Høiland-Jørgensen
2024-12-06 4:07 ` Mina Almasry
2024-12-03 17:37 ` [PATCH net-next v6 09/10] page_pool: allow mixing PPs within one bulk Alexander Lobakin
2024-12-06 2:40 ` Jakub Kicinski
2024-12-06 13:49 ` Alexander Lobakin
2024-12-06 16:20 ` Jakub Kicinski
2024-12-03 17:37 ` [PATCH net-next v6 10/10] xdp: get rid of xdp_frame::mem.id Alexander Lobakin
2024-12-06 7:10 ` [PATCH net-next v6 00/10] xdp: a fistful of generic changes pt. I patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmgfaglm.fsf@toke.dk \
--to=toke@redhat.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).