From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: tiwai@suse.de, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, apais@linux.microsoft.com,
edmund.raile@protonmail.com, linux-media@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] ALSA: firewire: use nonatomic PCM operation
Date: Wed, 04 Sep 2024 18:07:54 +0200 [thread overview]
Message-ID: <87wmjrh06d.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240904125155.461886-6-o-takashi@sakamocchi.jp>
On Wed, 04 Sep 2024 14:51:54 +0200,
Takashi Sakamoto wrote:
>
> In the former commits, the callback of isochronous context runs on usual
> work process. In the case, ALSA PCM device has a flag, nonatomic, to
> acquire mutex lock instead of spin lock for PCM substream group.
>
> This commit uses the flag. It has an advantage in the case that ALSA PCM
> application uses the large size of intermediate buffer, since it takes
> too long time even in tasklet softIRQ to process many of isochronous
> packets, then result in the delay of system event due to disabled IRQ so
> long. It is avertible to switch to nonatomic operation.
>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Feel free to take my ack:
Reviewed-by: Takashi Iwai <tiwai@suse.de>
thanks,
Takashi
next prev parent reply other threads:[~2024-09-04 16:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 12:51 [PATCH 0/5] firewire: use sleepable workqueue to handle 1394 OHCI IT/IR context events Takashi Sakamoto
2024-09-04 12:51 ` [PATCH 1/5] firewire: core: allocate workqueue to handle isochronous contexts in card Takashi Sakamoto
2024-09-04 12:51 ` [PATCH 2/5] firewire: core: add local API to queue work item to workqueue specific to isochronous contexts Takashi Sakamoto
2024-09-04 16:07 ` Takashi Iwai
2024-09-05 8:07 ` Takashi Sakamoto
2024-09-04 12:51 ` [PATCH 3/5] firewire: ohci: operate IT/IR events in sleepable work process instead of tasklet softIRQ Takashi Sakamoto
2024-09-04 12:51 ` [PATCH 4/5] firewire: core: non-atomic memory allocation for isochronous event to user client Takashi Sakamoto
2024-09-04 12:51 ` [PATCH 5/5] ALSA: firewire: use nonatomic PCM operation Takashi Sakamoto
2024-09-04 16:07 ` Takashi Iwai [this message]
2024-09-05 8:08 ` Takashi Sakamoto
2024-09-05 8:33 ` [PATCH 0/5] firewire: use sleepable workqueue to handle 1394 OHCI IT/IR context events Takashi Sakamoto
2024-09-12 21:44 ` firewire: use sleepable workqueue to handle 1394 OHCI IT/IR context events: test 2 Edmund Raile
2024-09-13 9:38 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmjrh06d.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=apais@linux.microsoft.com \
--cc=edmund.raile@protonmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).