From: Petr Machata <petrm@nvidia.com>
To: Gwangrok Baek <zester926@gmail.com>
Cc: <netdev@vger.kernel.org>, <kuba@kernel.org>, <mkubecek@suse.cz>,
<ahmed.zaki@intel.com>, <ecree@solarflare.com>
Subject: Re: [PATCH ethtool v2] ethtool: fix argument check in do_srxfh function to prevent segmentation fault
Date: Thu, 8 Aug 2024 10:09:37 +0200 [thread overview]
Message-ID: <87wmkrmlps.fsf@nvidia.com> (raw)
In-Reply-To: <CAHcxVNOf38nOzoWZ6cxxFUpvkfHPYa+DFZ4tBBYBntkLag93Gw@mail.gmail.com>
Gwangrok Baek <zester926@gmail.com> writes:
> Ensure that do_srxfh function in ethtool.c checks for the presence of
> additional arguments when context or xfrm parameter is provided before
> performing strcmp. This prevents segmentation faults caused by missing
> arguments.
>
> Without this patch, running 'ethtool -X DEVNAME [ context | xfrm ]' without
> additional arguments results in a segmentation fault due to an invalid
> strcmp operation.
>
> Fixes: f5d55b967e0c ("ethtool: add support for extra RSS contexts and
> RSS steering filters")
As Jakub wrote on v1, the Fixes: tag should not be line-wrapped.
prev parent reply other threads:[~2024-08-08 9:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 13:09 [PATCH ethtool v2] ethtool: fix argument check in do_srxfh function to prevent segmentation fault Gwangrok Baek
2024-08-08 8:09 ` Petr Machata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmkrmlps.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=ahmed.zaki@intel.com \
--cc=ecree@solarflare.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=zester926@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).