netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Peter Münster" <pm@a16n.net>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org,  Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net] net: b44: set pause params only when interface is up
Date: Thu, 18 Apr 2024 22:26:53 +0200	[thread overview]
Message-ID: <87wmou5sdu.fsf@a16n.net> (raw)
In-Reply-To: <e5d3c578-6142-4a30-9dd8-d5fca49566e0@lunn.ch> (Andrew Lunn's message of "Thu, 18 Apr 2024 20:55:57 +0200")

[-- Attachment #1: Type: text/plain, Size: 558 bytes --]

On Thu, Apr 18 2024, Andrew Lunn wrote:

> Please include a Fixed: tag indicating when the problem was added.

Hi Andrew,

I’m sorry, I don’t know, when the problem was added. I only know, that
there was no problem with OpenWrt < 23.X. But I don’t know why. Perhaps
the behaviour of netifd has changed from 22.X to 23.X.

So I guess, that the problem is there since the creation of
b44_set_pauseparam(), but it has never been triggered before.

So what should I do please with the Fixed: tag?

TIA for any hints,
-- 
           Peter

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

  reply	other threads:[~2024-04-18 20:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18 14:12 [PATCH net] net: b44: set pause params only when interface is up Peter Münster
2024-04-18 18:55 ` Andrew Lunn
2024-04-18 20:26   ` Peter Münster [this message]
2024-04-18 20:40     ` Michael Chan
2024-04-18 20:44       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmou5sdu.fsf@a16n.net \
    --to=pm@a16n.net \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).