From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27511C63797 for ; Tue, 17 Jan 2023 10:39:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236594AbjAQKj0 (ORCPT ); Tue, 17 Jan 2023 05:39:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236888AbjAQKix (ORCPT ); Tue, 17 Jan 2023 05:38:53 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C371031E30 for ; Tue, 17 Jan 2023 02:33:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673951623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h3KJE79yIHnB29huev91c70DW7KrTtxOmGhEtqUkXQA=; b=ei33oRF4CMCWiRHbzQXF7deMpnI4DyESxF9NnXmKSk5Jo9freyHp6pXGV334PIJmNS6IIr 3TGRAzWdD2kADCWdjZPPqocOJ3HV/emPKUkDtPFo2r20blCiBtHNnl6DkYuPZqKrOxJ3fc xZuAemdg9m4djP6ucfmg3nc3e2UHBsQ= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-126-VtCkPBTUOqq5B_lJAxnglw-1; Tue, 17 Jan 2023 05:33:42 -0500 X-MC-Unique: VtCkPBTUOqq5B_lJAxnglw-1 Received: by mail-ed1-f71.google.com with SMTP id t17-20020a056402525100b0049e0d2dd9b1so4101340edd.11 for ; Tue, 17 Jan 2023 02:33:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h3KJE79yIHnB29huev91c70DW7KrTtxOmGhEtqUkXQA=; b=Hle8XmUU8JK2KKqE/o609yvLEvvz65j5gnQMX/f+Wil8PXn2zYONUrnK7TpQPM03Rb RQgofdwJH0rRsbIXQl3oNJ0O+OhMYkES6ZC0SL9AAY3vtQe+cJNHezlkOolheg+XYAIH Zonp8DD+Zdvj5c+CA1sqCOfMueUCrjioDbQxmBlOYPuPgtC7x4aPTNC91eY7C3w+Wr7Y wgfcDsGLfoqOjMNdh64qA1cFL+bciYGde3e2FczO3+S9S19f2Ye2RjJ9Q7eAJm2TVHOq FZ7+cJQxe+akf+L77EuRsUnETuKw6XWkXwUhrXlVeWB+bJIwkBVpO52GJdvzXgT16bkC RwTw== X-Gm-Message-State: AFqh2kr0Efd7IitczMmOEDg1jmGa3cjJgp7BrwWVSQmG0euhnMqh/Tm9 b14lukAjWJQPl/KAcEHND+1WINq5jEld/IJfhASQlZC5XT2vsO9J9EW0W8i9kwUVWAa+SqneJ/p +PkyQu8jLeHPGvnxr X-Received: by 2002:a17:907:6e2a:b0:871:e9a0:eba7 with SMTP id sd42-20020a1709076e2a00b00871e9a0eba7mr2969689ejc.57.1673951620794; Tue, 17 Jan 2023 02:33:40 -0800 (PST) X-Google-Smtp-Source: AMrXdXvxXlQdblReVhkBfD9P6awdd+C/UXYFiXv29qCEooauRA+hTsykeWRfwP7ivJWOaj0mQlejSw== X-Received: by 2002:a17:907:6e2a:b0:871:e9a0:eba7 with SMTP id sd42-20020a1709076e2a00b00871e9a0eba7mr2969651ejc.57.1673951620059; Tue, 17 Jan 2023 02:33:40 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id sb25-20020a1709076d9900b007a4e02e32ffsm13046805ejc.60.2023.01.17.02.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 02:33:39 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 28D579010D2; Tue, 17 Jan 2023 11:33:35 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Magnus Karlsson , magnus.karlsson@intel.com, bjorn@kernel.org, ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org, jonathan.lemon@gmail.com, maciej.fijalkowski@intel.com, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net, brouer@redhat.com Cc: bpf@vger.kernel.org Subject: Re: [PATCH net-next] xdp: document xdp_do_flush() before napi_complete_done() In-Reply-To: <20230117094305.6141-1-magnus.karlsson@gmail.com> References: <20230117094305.6141-1-magnus.karlsson@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 17 Jan 2023 11:33:35 +0100 Message-ID: <87wn5lcuww.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Magnus Karlsson writes: > From: Magnus Karlsson > > Document in the XDP_REDIRECT manual section that drivers must call > xdp_do_flush() before napi_complete_done(). The two reasons behind > this can be found following the links below. > > Signed-off-by: Magnus Karlsson > Link: https://lore.kernel.org/r/20221220185903.1105011-1-sbohrer@cloudfla= re.com > Link: https://lore.kernel.org/all/20210624160609.292325-1-toke@redhat.com/ Thanks for fixing this! Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen