From: Petr Machata <petrm@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Petr Machata <petrm@nvidia.com>, Ido Schimmel <idosch@nvidia.com>,
<netdev@vger.kernel.org>, <davem@davemloft.net>,
<jiri@nvidia.com>, <razor@blackwall.org>, <roopa@nvidia.com>,
<dsahern@gmail.com>, <andrew@lunn.ch>, <mlxsw@nvidia.com>
Subject: Re: [PATCH net-next 06/14] net: dev: Add hardware stats support
Date: Fri, 25 Feb 2022 21:01:53 +0100 [thread overview]
Message-ID: <87wnhid7l8.fsf@nvidia.com> (raw)
In-Reply-To: <20220225095645.547a79f0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Jakub Kicinski <kuba@kernel.org> writes:
> On Fri, 25 Feb 2022 18:00:11 +0100 Petr Machata wrote:
>> > What I meant is take out all the link-level / PHY stuff, I don't think
>> > any HW would be reporting these above the physical port. Basically when
>> > you look at struct rtnl_link_stats64 we can remove everything starting
>> > from and including collisions, right?
>>
>> My thinking is that stats64 is understood, e.g. formatting this in the
>> iproute2 suite is just a function call away. I imagine this is similar
>> in other userspace tools as well. There are benefits to just reusing
>> what exists, despite not being optimal.
>>
>> But yeah, those 120 trail bytes are very likely going to be zero.
>> I can shave them if you feel strongly about it.
>
> Yeah, if I'm counting right we're reusing like 38% of the fields, only.
> We're better off with a new structure.
OK.
next prev parent reply other threads:[~2022-02-25 20:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 13:33 [PATCH net-next 00/14] HW counters for soft devices Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 01/14] net: rtnetlink: Namespace functions related to IFLA_OFFLOAD_XSTATS_* Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 02/14] net: rtnetlink: Stop assuming that IFLA_OFFLOAD_XSTATS_* are dev-backed Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 03/14] net: rtnetlink: RTM_GETSTATS: Allow filtering inside nests Ido Schimmel
2022-02-25 6:14 ` Jakub Kicinski
2022-02-25 8:22 ` Petr Machata
2022-02-25 16:04 ` Jakub Kicinski
2022-02-25 16:57 ` Petr Machata
2022-02-24 13:33 ` [PATCH net-next 04/14] net: rtnetlink: Propagate extack to rtnl_offload_xstats_fill() Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 05/14] net: rtnetlink: rtnl_fill_statsinfo(): Permit non-EMSGSIZE error returns Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 06/14] net: dev: Add hardware stats support Ido Schimmel
2022-02-25 6:22 ` Jakub Kicinski
2022-02-25 8:31 ` Petr Machata
2022-02-25 16:12 ` Jakub Kicinski
2022-02-25 17:00 ` Petr Machata
2022-02-25 17:56 ` Jakub Kicinski
2022-02-25 20:01 ` Petr Machata [this message]
2022-02-25 22:37 ` Jakub Kicinski
2022-02-24 13:33 ` [PATCH net-next 07/14] net: rtnetlink: Add UAPI for obtaining L3 offload xstats Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 08/14] net: rtnetlink: Add RTM_SETSTATS Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 09/14] net: rtnetlink: Add UAPI toggle for IFLA_OFFLOAD_XSTATS_L3_STATS Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 10/14] mlxsw: reg: Fix packing of router interface counters Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 11/14] mlxsw: spectrum_router: Drop mlxsw_sp arg from counter alloc/free functions Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 12/14] mlxsw: Extract classification of router-related events to a helper Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 13/14] mlxsw: Add support for IFLA_OFFLOAD_XSTATS_L3_STATS Ido Schimmel
2022-02-24 13:33 ` [PATCH net-next 14/14] selftests: forwarding: hw_stats_l3: Add a new test Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnhid7l8.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).