From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80097C4332B for ; Sun, 14 Mar 2021 20:22:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 528AD64EB7 for ; Sun, 14 Mar 2021 20:22:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233641AbhCNUWN (ORCPT ); Sun, 14 Mar 2021 16:22:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234497AbhCNUVo (ORCPT ); Sun, 14 Mar 2021 16:21:44 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258C0C061762 for ; Sun, 14 Mar 2021 13:21:44 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id r20so13817794ljk.4 for ; Sun, 14 Mar 2021 13:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=KhQ8GQxemSKjASj94bgK9DXuv0kgFGsdClfGRmeqb+w=; b=dMXp6S+xwIo7qP43hDz1KOxUK23QlXQC8lOseG8YAKVLaZg2QtX2z3Aq+wqZwyh021 WHFMGrVl8mVdp8TTB97gVZ0ORswGNaiiSaJfjaZfvq/CDBdqfS3t4YK6pkr8klGfD4Ol nDbvnzmqQad3kg7iIox5KpBbRdOxU/IQi848E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=KhQ8GQxemSKjASj94bgK9DXuv0kgFGsdClfGRmeqb+w=; b=NvNlxgn73DfB6sILrEFZnpQ/v0PLV5PONL+qRXYZs83gMpES+cN/M3it1pwAxZnoAX +8jiOTIKoLoWmg0wmM5MwkhzpVRbfjgCpQ+OfbjrWFVwYys9JjZmmTdDsHMwJDSnVpmx 9IZy0+c4gvWsvyPz2yO8GAxGF3Dx9wdoyantdh/n9HAguT2t3xnFUz8+x1Jet1MnCLU+ XrmAzhnitBSBIXT3WNX1UWIMrhp/YNBde8QNM118ZCH76htsMFZpFjzgINg3UH1BnM44 gWSfVu/KnZ6zd4g2/7zXbqbepX+AY0AQz+A//SXRRBO04OoUBdBqfMEVk//mSD4xxoDI t6Sg== X-Gm-Message-State: AOAM531bIpuSIAHfEH/ZRl8JgmkzTTg/IJKB/h4ER017+DXUWQNEDh1r 4cl6DG1Ndx2TKKzMxT6xTpgUEA== X-Google-Smtp-Source: ABdhPJyaVF0NfVWRWlYfaHfhZnBf7kwTVOPbbgbemIDf5TMA56r32ijF7G9Bw0rI3WwN2lhtP8cgeQ== X-Received: by 2002:a2e:85d9:: with SMTP id h25mr2316715ljj.81.1615753302434; Sun, 14 Mar 2021 13:21:42 -0700 (PDT) Received: from cloudflare.com (83.31.58.229.ipv4.supernova.orange.pl. [83.31.58.229]) by smtp.gmail.com with ESMTPSA id h23sm2439198lfm.299.2021.03.14.13.21.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Mar 2021 13:21:41 -0700 (PDT) References: <20210312200834.370667-1-alobakin@pm.me> User-agent: mu4e 1.1.0; emacs 27.1 From: Jakub Sitnicki To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Andrii Nakryiko , Vladimir Oltean , Davide Caratti , Guillaume Nault , wenxu , Eran Ben Elisha , Matteo Croce , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID In-reply-to: <20210312200834.370667-1-alobakin@pm.me> Date: Sun, 14 Mar 2021 21:21:40 +0100 Message-ID: <87wnu932qz.fsf@cloudflare.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote: > flow_dissector_key_icmp::id is of type u16 (CPU byteorder), > ICMP header has its ID field in network byteorder obviously. > Sparse says: > > net/core/flow_dissector.c:178:43: warning: restricted __be16 degrades to integer > > Convert ID value to CPU byteorder when storing it into > flow_dissector_key_icmp. > > Fixes: 5dec597e5cd0 ("flow_dissector: extract more ICMP information") > Signed-off-by: Alexander Lobakin > --- > net/core/flow_dissector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c > index 2ef2224b3bff..a96a4f5de0ce 100644 > --- a/net/core/flow_dissector.c > +++ b/net/core/flow_dissector.c > @@ -176,7 +176,7 @@ void skb_flow_get_icmp_tci(const struct sk_buff *skb, > * avoid confusion with packets without such field > */ > if (icmp_has_id(ih->type)) > - key_icmp->id = ih->un.echo.id ? : 1; > + key_icmp->id = ih->un.echo.id ? ntohs(ih->un.echo.id) : 1; > else > key_icmp->id = 0; > } Smells like a breaking change for existing consumers of this value. How about we change the type of flow_dissector_key_icmp{}.id to __be16 instead to make sparse happy?