From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
Johannes Berg <johannes@sipsolutions.net>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>,
Felix Fietkau <nbd@nbd.name>,
linux-wireless@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] mac80211: set NETIF_F_LLTX when using intermediate tx queues
Date: Tue, 16 Apr 2019 14:18:36 +0100 [thread overview]
Message-ID: <87wojut7f7.fsf@toke.dk> (raw)
In-Reply-To: <20190416131346.u2uolljlrd5t2jro@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> writes:
> On Tue, Apr 16, 2019 at 11:39:56AM +0200, Johannes Berg wrote:
>>
>> > not to mention
>> > breaking certain applications that rely on congestion feedback?
>>
>> This I don't understand. The congestion feedback happens through socket
>> buffer space etc. which is still there (as long as nobody sneaks in an
>> skb_orphan() call)
>
> The congestion control happens at two levels. You are right that the
> socket buffer acts as one limit. However, other applications may also
> rely on the TX queue being full as the throttle (by setting a
> sufficiently large socket buffer size).
Do you happen to have an example of an application that does this that
could be used for testing? :)
-Toke
next prev parent reply other threads:[~2019-04-16 13:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190316170634.13125-1-nbd@nbd.name>
[not found] ` <20190316170634.13125-5-nbd@nbd.name>
[not found] ` <87sgvmvg9g.fsf@toke.dk>
[not found] ` <773e4dff-29fd-22b4-e4bc-cd5a94c66dc2@broadcom.com>
[not found] ` <20190416074444.pdubbh6fbibdnhi7@gondor.apana.org.au>
[not found] ` <73b18131-2777-da5c-a6ee-9d9b3e13cd06@broadcom.com>
[not found] ` <20190416083636.5ttvezqyhzr2worg@gondor.apana.org.au>
[not found] ` <eab39dd804405854997e50102f3d0ff925feb8d2.camel@sipsolutions.net>
[not found] ` <cd0715bb-b75c-63b0-0ae4-858d14afd500@broadcom.com>
2019-04-16 9:29 ` [PATCH 5/5] mac80211: set NETIF_F_LLTX when using intermediate tx queues Herbert Xu
[not found] ` <87ef62uwfm.fsf@toke.dk>
[not found] ` <95f86cf69dee05a176625925657cf0df0e97b5c9.camel@sipsolutions.net>
2019-04-16 9:37 ` Herbert Xu
2019-04-16 9:39 ` Johannes Berg
2019-04-16 10:02 ` Toke Høiland-Jørgensen
2019-04-17 2:11 ` Herbert Xu
2019-04-17 8:28 ` Toke Høiland-Jørgensen
2019-04-16 13:13 ` Herbert Xu
2019-04-16 13:18 ` Toke Høiland-Jørgensen [this message]
2019-04-17 3:38 ` Herbert Xu
2019-04-17 9:09 ` Toke Høiland-Jørgensen
2019-04-17 9:16 ` Arend Van Spriel
2019-04-17 9:17 ` Toke Høiland-Jørgensen
2019-04-23 12:41 ` Johannes Berg
2019-04-25 8:35 ` Herbert Xu
2019-04-25 8:39 ` Johannes Berg
2019-04-25 8:44 ` Herbert Xu
2019-04-25 8:49 ` Johannes Berg
2019-04-16 19:13 ` Johannes Berg
2019-04-17 2:13 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wojut7f7.fsf@toke.dk \
--to=toke@redhat.com \
--cc=arend.vanspriel@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).