From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Axtens Subject: Re: [PATCH] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue Date: Fri, 16 Feb 2018 01:49:50 +1100 Message-ID: <87wozenw8h.fsf@linkitivity.dja.id.au> References: <20180205033433.23647-1-dja@axtens.net> <20180215132900.GB4716@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Cc: netdev@vger.kernel.org To: Marcelo Ricardo Leitner Return-path: Received: from mail-pg0-f42.google.com ([74.125.83.42]:37927 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032957AbeBOOt4 (ORCPT ); Thu, 15 Feb 2018 09:49:56 -0500 Received: by mail-pg0-f42.google.com with SMTP id l24so4378480pgc.5 for ; Thu, 15 Feb 2018 06:49:56 -0800 (PST) In-Reply-To: <20180215132900.GB4716@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: Hi Marcelo, > > If this block was meant to be an out-of-band/changelog comment, your > SOB line should be above the first --- marker. > Anyhow, > Reviewed-by: Marcelo Ricardo Leitner Thanks - I did a v2 with this around the right way [1], but DaveM asked me to be a bit more thorough and look for other GSO_BY_FRAGS issues. [2] I did find a couple, including the one I asked you about with qdisk_pkt_len_init [3] (thanks for your answer, btw). Currently I'm trying to wrap my head around GSO_DODGY as Eric mentioned on that thread, and then I'll do a series with this fix and the other GSO_BY_FRAGS fixes I find. Regards, Daniel [1] https://patchwork.ozlabs.org/patch/869145/ [2] https://patchwork.ozlabs.org/comment/1852414/ [3] https://www.spinics.net/lists/netdev/msg482397.html > >> --- >> net/sched/sch_tbf.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c >> index 229172d509cc..03225a8df973 100644 >> --- a/net/sched/sch_tbf.c >> +++ b/net/sched/sch_tbf.c >> @@ -188,7 +188,8 @@ static int tbf_enqueue(struct sk_buff *skb, struct Qdisc *sch, >> int ret; >> >> if (qdisc_pkt_len(skb) > q->max_size) { >> - if (skb_is_gso(skb) && skb_gso_mac_seglen(skb) <= q->max_size) >> + if (skb_is_gso(skb) && >> + skb_gso_validate_mac_len(skb, q->max_size)) >> return tbf_segment(skb, sch, to_free); >> return qdisc_drop(skb, sch, to_free); >> } >> -- >> 2.14.1 >>